I have a listview with clickable buttons in the row views, and a custom SimpleCursorAdapter to implement this list. Despite the onitemclicklistener not being fired when the row is clicked (see here), I have implemented a listener that works when touching the row item:
public View getView(int position, View convertView, ViewGroup parent) {
.................................
convertView.setOnClickListener(new OnItemClickListener(position));
}
public class OnItemClickListener implements OnClickListener{
private int mPosition;
OnItemClickListener(int position){
mPosition = position;
}
public void onClick(View view) {
}
}
There are two problems with this - it takes two touches to fire the onitemclick listener, presumably one to focus and one to fire, and it's impossible to select the row using the trackball.
I have tried some of the workaround listed on SO, inlcuding making the button not focusable, and some other methods here, but didn't get anywhere. As that link points out, Google accomplish it themselves with the call log application. That seems to be achieved with ListActivities though - I am using a Tab Activity with several lists in the same tab.
I managed to sort out both issues in the end with a TouchDelegate. The relevant code I used in my Custom Adapter is below. I used the TouchableDelegate on an ImageView, so I'm pretty sure most other objects would also work. TOUCH_RECT_EXPANSION is just a constant parameter for how much you want the bounding box to be expanded by. Also note that your Custom Adapter must implement View.OnTouchListener.
public View getView(int position, View convertView, ViewGroup parent) {
star = (ImageView) convertView.findViewById(R.id.liststar);
final View parentview = (View) star.getParent();
parentview.post( new Runnable() {
// Post in the parent's message queue to make sure the parent
// lays out its children before we call getHitRect()
public void run() {
final Rect r = new Rect();
star.getHitRect(r);
r.top -= TOUCH_RECT_EXPANSION;
r.bottom += TOUCH_RECT_EXPANSION;
r.left -= TOUCH_RECT_EXPANSION;
r.right += TOUCH_RECT_EXPANSION;
parentview.setTouchDelegate( new TouchDelegate(r,star) {
public boolean onTouchEvent(MotionEvent event) {
return true;
}
});
}
});
star.setOnTouchListener(this);
}
public boolean onTouch(View v, MotionEvent event) {
if (event.getAction() == MotionEvent.ACTION_UP) {
// do something here
}
return true;
}
}
I also had some issues with the onItemClickListener. In the end these were solved by using a separate custom class that implemented the interface OnItemClickListener, so try that if you are having problems, but it's probably more likely that I was doing something wrong with the in-class onItemClickListener, because I can't see any reason why that should work differently.
Related
I have an Activity, inside is ViewPager and inside is ListFragment with ListView items. I want define touch gesture for the items (drag, fling etc.).
I'm able to attach onTouchListener() to each ListView item View by overriding getView() of adapter.
Adapter adapter = new Adapter(blah, blah, blah) {
#Override
public View getView(final int position, View convertView, ViewGroup parent) {
View itemView = super.getView(position, convertView, parent);
itemView.setOnTouchListener(new View.OnTouchListener() {
blah, blah, blah
});
return itemView;
}
};
But I only receive MotionEvent.ACTION_DOWN, MotionEvent.ACTION_MOVE and MotionEvent.ACTION_UP if it occurs inside triggering item View boundary. For example I'm not able to catch MotionEvent.ACTION_OUTSIDE.
My guess is, that my custom onTouchListener compete with listener of ViewPager and of Activity. I want to trigger these other listeners in some occasions, i.e. if user move to side, I want to slide the whole View inside ViewPager but if he push on the ListView item and move vertically, I want startDrag() of the item.
How to implement that?
Edit/ Currently, my custom listener on ListView items works along with ViewPager, which is great. I'm able to catch ListView item events as long as I don't move outside its View and I'm able to slide the whole View in ViewPager as well.
Edit/ I've rewrote my ListView into RecycledView and realized that if I attach listener to item View, the ViewPager catches almost all move events, while allowing only the click events to go through. I've also realized, that if I attach OnTouchListener to the RecycledList it is able to catch move events along with the ViewPager so it depends on which level I attach the Listener. Problem is, that in item View level I have available full reference to item, while when working with the list, I need to guess item position from event coordinates and then gather data from Adapter and RecycledView, which is extra work.
Edit/ it wasn't that hard after all. Luckily, RecycledView has findChildViewUnder(int xPos, int yPos) method, so getting the View was piece of cake.
Here's my implementation, if someone is interested
mRecycledView.setOnTouchListener(new View.OnTouchListener() {
int LONG_PRESS_TIMEOUT = ViewConfiguration.getLongPressTimeout();
float mItemViewHeight, mInitialY;
boolean mIsResolved;
final Handler mHandler = new Handler(Looper.getMainLooper());
final Runnable mLongPress = new Runnable() {
#Override
public void run() {
mIsResolved = true;
onLongClick();
}
};
#Override
public boolean onTouch(View v, MotionEvent me) {
switch (MotionEventCompat.getActionMasked(me)) {
case MotionEvent.ACTION_DOWN:
mInitialY = me.getY();
mActiveUserView = mRecycledView.findChildViewUnder(me.getX(), mInitialY);
if (mActiveUserView == null) { // clicked to RecycledView where's no item
mIsResolved = true;
} else {
mIsResolved = false;
mItemViewHeight = (float) mActiveUserView.getHeight();
mHandler.postDelayed(mLongPress, LONG_PRESS_TIMEOUT);
}
break;
case MotionEvent.ACTION_MOVE:
if (!mIsResolved) {
stopLongClickHandler();
// check for vertical upward move
if (mInitialY - me.getY() > mItemViewHeight) {
mIsResolved = true;
onVerticalDrag();
}
}
break;
case MotionEvent.ACTION_UP:
if (!mIsResolved) {
stopLongClickHandler();
mIsResolved = true;
onClick();
}
}
return !mIsResolved;
}
void stopLongClickHandler() {
mHandler.removeCallbacksAndMessages(null);
}
void onVerticalDrag() {
Log.e("DEBUG", "start drag");
}
void onLongClick() {
Log.e("DEBUG", "long click");
}
void onClick() {
Log.e("DEBUG", "short click");
}
});
I can suggest you replacing ListView with RecyclerView. Then read this tutorial: it contains almost every drag/swipe/touch implementations on RecyclerView clearly explained.
My primary goal is to know which item in my listView is focused with an accessibility focus by the Explore by touch.
Because I'm working on an application, I can't have access to the accessibility service methods for this behavior.
The best thing would be to have an onItemHoverListener like onItemClickListener:
listView.setOnItemHoverListener(new OnItemHoverListener(){
public void onItemHover(AdapterView<?> parent, View v, int position, long id)
{
//Can know here which item is focused by Explore by touch
//Can get the position of this item in my listview
}
});
What else can I do to get this behavior?
You can observe accessibility focus changes by watching for TYPE_VIEW_ACCESSIBILITY_FOCUSED events, either by overriding onRequestSendAccessibilityEvent on a parent view or setting an AccessibilityDelegate on a parent view that overrides this method.
myListView.setAccessibilityDelegate(new MyDelegate());
Where the delegate is defined as something like:
class MyDelegate extends AccessibilityDelegate {
...
public boolean onRequestSendAccessibilityEvent(ViewGroup host, View child,
AccessibilityEvent event) {
if (host == myListView) {
int childPosition = myListView.getPositionForView(child);
...
}
}
}
I'm having a hard time trying to figure this out. I have a gridview of 8 buttons. At the moment I'm using an onItemClickListener to trigger the buttons actions, however this produces two problems for me.
1) The buttons action happens after the button has been unpressed.
2) Two buttons cannot the pressed at the same time, you must release the first button.
As I have learnt, an onTouchListener should resolve my first issue, though I'm not sure how to determine which button has been pressed. My code for the onItemClickListener is as follows
gridview.setOnItemClickListener(new OnItemClickListener() {
public void onItemClick(AdapterView<?> parent, View v, int position, long id) {
Toast.makeText(Activity.this, "" + position, Toast.LENGTH_SHORT).show();
}
});
Now with the above, I know exactly which button has been pushed. I believe the code for implementing as an onTouchListener is as follows
gridview.setOnTouchListener(new OnTouchListener() {
public boolean onTouch(View v, MotionEvent event) {
return false;
}
}) {
How am I supposed to determine which button has been pressed using MotionEvent? Before I was getting passed 'position' and it made this fairly easy. I also need to account for if two or more buttons have been pushed simultaneously/without letting another one go.
Does anyone know how to achieve this?
Having hit this very issue recently and coming across this post in my quest for help, I wanted to add two things from what I did which seem to have worked:
1) I added the onTouchListener to the object in the adapter rather than the activity or gridview.
2) In the OnTouchListener, I looked for MotionEvent.ACTION_DOWN (first finger touch) and MotionEvent.ACTION_POINTER_DOWN (subsequent finger touches), this way I can get multitouches and process them immediately without waiting for the user to lift their finger(s).
Note that I called it ImageAdapter, even though I've added a TextView to each as that way I can use the TextView background for the image, but add invisible text to the TextView so it works with Talkback):
public class ImageAdapter extends BaseAdapter {
private Context mContext;
public ImageAdapter(Context c) {
mContext = c;
}
public int getCount() {
return numCols * numRows;
}
public Object getItem(int position) {
return this;
}
public long getItemId(int position) {
return position;
}
// create a new TextView for each item referenced by the Adapter
public View getView(int position, View convertView, ViewGroup parent) {
TextView textView;
if (convertView == null) { // if it's not recycled, initialize some attributes
textView = new TextView(mContext);
} else {
textView = (TextView) convertView;
}
// place any other initial setup needed for the TextView here
// here's our onTouchListener
textView.setOnTouchListener(new View.OnTouchListener() {
public boolean onTouch(View v, MotionEvent event) {
boolean returnValue;
int thePosition = v.getId();
// MotionEvent.ACTION_DOWN gets the first touch
// MotionEvent.ACTION_POINTER_DOWN gets any subsequent touches (if you place a second finger on the screen)
// Between these I can get touches as soon as they happen, including multitouch support, without needing to wait until the user lifts their finger.
if ((event.getAction() == MotionEvent.ACTION_DOWN) || (event.getAction() == MotionEvent.ACTION_POINTER_DOWN)) {
TextView textView;
if (v == null) { // if it's not recycled, initialize some attributes
textView = new TextView(mContext);
} else {
textView = (TextView) v;
}
// Do any processing based on the touch - I call a function and pass the position (number of cell, 1..n) and textview so can make changes to it as needed
ScreenTapped(thePosition, textView);
// I used a returnValue
returnValue = true;
} else returnValue = false;
return returnValue;
});
return textView;
} // getView
} //imageadapter
I am infact trying to figure the same thing out. I got as far as figuring out which gridcell has been clicked using the following code
public boolean onTouch(View v, MotionEvent me) {
float currentXPosition = me.getX();
float currentYPosition = me.getY();
int position = gridView.pointToPosition((int) currentXPosition, (int) currentYPosition);
Position gives you the number on the gridView, and you can supposedly retrieve that particular item as following
gridView.getItemAtPosition(position)
But that is where I am stuck. My gridView has Textview items in it, and I am having trouble converting the item to a textview and then performing operations on it.
Hope this helps!
When using gridView the philosophy is:
the grid view implements the onTouchLister
when touch happens onTouchLister gathers the coordinates (a lot :) )
for all ACTION_MOVE events
when the touch event is MOVE_UP, calculate the real positions under
the coordinates and return the item in the grid
So the solution would be:
In your activity where you have findViewById(some_grid_view)
//Register handler for the onTouch event of gridView in your activity
gridView.setOnTouchListener(new MyActivityOnTouchListener(this));
NOTE: my onTouch listener is implemented in another class (MyActivityOnTouchListener) instead of inside the activity
...then in the MyActivityOnTouchListener class you implement the onTouch method:
public class CalendarActivityOnTouchListener implements View.OnTouchListener {
private MyActivity myActivityContext;
private GridView mGridView;
private HashSet<Point> movementCoordinates = new HashSet<Point>;
//Constructor
public MyActivityOnTouchListener (MyActivity context){
this.myActivityContext= context;
mGridView= myActivityContext.getGridView(); //assign touched gridView into a local variable
}
#Override
public boolean onTouch(View v, MotionEvent event) {
/*
* NOTE:
* ACTION_MOVE fires events until you release it
* ACTION_UP once you release it fires it
*/
//while touching the grid a bunch of ACTION_MOVE events are dispatched
if (event.getAction() == MotionEvent.ACTION_MOVE) {
//gather all coordinates touched (in a set to avoid duplicates)
movementCoordinates.add(new Point((int)event.getX(), (int)event.getY()));
return true;
}
//Finally the finger is lifted
if (event.getAction() == MotionEvent.ACTION_UP) {
//convert all movementCoordinates gathered in the previous block into real grid positions
int position;
for(Point p : movementCoordinates){
Log.d("Luka", p.x +" / "+p.y);
position = calendarGridView.pointToPosition(p.x, p.y);
//...Do whatever with the position
}
}
}
}
Be careful about the pointToPosition() method because in some cases it can return -1 instead of the position behind the coordinates. For example, if you have a margin between items in the grid those coordinates cannot return a position, hence the -1
hope it helps...
I'm trying to get the list item number in the onTouch method. That is how i do it:
ListView myList;
...
myList.setOnTouchListener(new OnTouchListener() {
#Override
public boolean onTouch(View v, MotionEvent event) {
doSomething(myList, event);
return false;
}
});
...
private void doSomething(ListView myList, MotionEvent event) {
if (event.getAction() == MotionEvent.ACTION_DOWN) {
int first = myList.getFirstVisiblePosition();
int last = myList.getLastVisiblePosition();
int itemHeight = myList.getHeight() / (last - first + 1) + myList.getDividerHeight();
int position = (int)event.getY() / itemHeight;
View child = myList.getChildAt(position);
...
It seems to be not correct, because sometimes I get wrong position. How can i fix it?
Why don't you set an onTouchListener for the ListView items instead?
If you're using a custom adapter for your ListView, make it implement OnTouchListener and set setOnTouchListener(this) on your ListView items in the getView(int position, View convertView, ViewGroup parent)-method.
If you're trying to manipulate the ListView-items, that should do the trick.
If you're just trying to get the position, use convertView.setOnTouchListener(new OnTouchListener() { ... read position and do something ... } ); in getView(...).
Update
If you're just trying to change backgroundcolor/textcolor (imageview content), you can use statelist-drawables.
For changing textcolor onItemCLick, see this question and answer and set the drawable you created as a textColor for your TextView. For the listitem's backgroundcolor, create a custom listselector (more info, see this question). You can also change the ImageView's content in the same way: create a StateListDrawable and set it as the ImageView's source.
you should use an AdapterView.OnItemClickListener and set it with setOnItemClickListener (AdapterView.OnItemClickListener listener) method. It has an onItemClick(AdapterView parent, View view, int position, long id) method and the position variable will be the number of the row in the listview
I have used gallery in my app.
In that i have two images in each gallery item like this
Each rabbit and mouse image is combined as a single gallery item.
So I give onclickListener for both images but if I give like that I can't scroll by touching those images... If I remove onClickListener for that individual images I am able to scroll.
How to archive both scroll and onClick for each images.
This answers your question. You have to let your activity handle both onClick and Gestures.
In my case I just used the Gallery.setOnItemClickListener with the Listener handling the callback to the parent Activity.
When I had the Activity listening as in the the solution above the clicks didn't register for me.
I faced to this problem too. And after 2 days working, I found a perfect solution for this:
Set onItemClickListener for gallery too.
On the activity, listen to onTouchEvent of gallery and activity, write down the raw coordinate
#Override
public boolean onTouch(View v, MotionEvent event) {
x = (int)event.getRawX();
y = (int)event.getRawY();
return false;
}
#Override
public boolean onTouchEvent(MotionEvent event) {
x = (int)event.getRawX();
y = (int)event.getRawY();
return super.onTouchEvent(event);
}
onItemClick for the gallery, you get each view inside it and check the click coordinate.
Rect frame = new Rect();
image[i].getGlobalVisibleRect(frame);
if (frame.contains(x, y)) {//do whatever you want}
I had this same problem but solved it pretty easy. What I did was is added setOnItemClickListener to the GalleryView and then grabbed the view that i wanted, which was in my case a TextView.
private boolean isVisble = true;
gallery_images.setOnItemClickListener(new OnItemClickListener() {
#Override
public void onItemClick(AdapterView<?> arg0, View arg1,
int arg2, long arg3) {
// TODO Auto-generated method stub
TextView image_text = ((TextView)arg1.findViewById(R.id.image_text));
if(!isVisble){
isVisble = true;
image_text.setVisibility(TextView.VISIBLE);
}
else{
isVisble = false;
image_text.setVisibility(TextView.GONE);
}
}
});
In your case you could first check which images are shown and based on that information you can maniuplate the view. Hope this helps
I have multiple galleries in my activity and I do it that way:
Implementing the OnItemClickListener:
public class ImageBoardActivity extends Activity implements OnItemClickListener {
Overriding onItemClick() method
#Override
public void onItemClick(AdapterView<?> parent, View view, int position, long arg3) {
// do what you want here...
}
My Solution:
don't do this!
:=)) (spend over 6 hours trying to solve this.. didnt work for me...)
used another Approach (different Layout)