I am trying to implement a thread that changes something on the UI in a Fragment. Therefore I need to refer to the main thread.
Based on my research, I've found that the following code should do the trick:
new Handler(Looper.getMainLooper()).post(new Runnable() {
#Override
public void run() {
Toast.makeText(menuActivity, "HELLO", Toast.LENGTH_SHORT).show();
}
});
This will execute only once though, even if the Looper should normally keep the thread alive. Trying to invoke Looper.prepare() inside the Handler will cause a RuntimeException as only one Looper is allowed per thread.
Edit: My goal is to update a TextView permanently each second.
I have also tried the following:
Thread t = new Thread() {
#Override
public void run() {
menuActivity.runOnUiThread(new Runnable() {
#Override
public void run() {
System.out.println("-----------TEST");
}
});
}
};
t.start();
But this will execute only once too.
I've also read this article, but I guess my first snippet of code is just a shorter version of the code shown in the article.
Where may my mistake be in any of these snippets of code?
This question is not a duplicate, due to the fact that I presented a totally different snippet of code which is the base of the problem I had. Furthermore, the Looper is explained more in depth in this thread.
I understand that you want to update a text view repeatedly after 1 seconds. Here is a simple demo I just write.
Mockup screen
activity_main.xml
<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:orientation="vertical">
<TextView
android:id="#+id/text_view_money"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginTop="10dp"
android:gravity="center"
android:textColor="#android:color/black"
android:textSize="20sp" />
<LinearLayout
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginBottom="30dp"
android:layout_marginTop="30dp"
android:orientation="horizontal">
<Button
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_weight="1"
android:onClick="startUpdateTextViewMoney"
android:text="Start" />
<Button
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_weight="1"
android:onClick="stopUpdateTextViewMoney"
android:text="Stop" />
</LinearLayout>
<LinearLayout
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:gravity="center"
android:orientation="horizontal">
<EditText
android:id="#+id/edit_text_money"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_weight="1" />
<Button
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:onClick="setMoney"
android:text="SET MONEY" />
</LinearLayout>
</LinearLayout>
MainActivity.java
public class MainActivity extends AppCompatActivity {
private static final int UPDATE_TEXT_MONEY_INTERVAL = 1000;
private Handler mMainHandler;
private TextView mTextViewMoney;
private TextView mEditTextMoney;
private String money;
private Runnable mUpdateTextViewMoneyTask = new Runnable() {
#Override
public void run() {
if (TextUtils.isEmpty(money)) {
mTextViewMoney.setText(String.valueOf(SystemClock.elapsedRealtime()));
} else {
mTextViewMoney.setText(money);
money = null;
}
mMainHandler.postDelayed(this, UPDATE_TEXT_MONEY_INTERVAL);
}
};
#Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_main);
mTextViewMoney = findViewById(R.id.text_view_money);
mEditTextMoney = findViewById(R.id.edit_text_money);
mMainHandler = new Handler(Looper.getMainLooper());
}
#Override
protected void onStop() {
super.onStop();
stopUpdateTextViewMoney(null);
}
public void startUpdateTextViewMoney(View view) {
mMainHandler.post(mUpdateTextViewMoneyTask);
}
public void stopUpdateTextViewMoney(View view) {
mMainHandler.removeCallbacks(mUpdateTextViewMoneyTask);
}
public void setMoney(View view) {
String money = mEditTextMoney.getText().toString();
this.money = !TextUtils.isEmpty(money) ? money : "";
}
}
When users press Start button, the app will start updating text view each second
When users press Stop button, the app will stop updating the text view.
If users want to set a new money to display in the next time, just enter in the edit text then press Set Money.
This will execute only once though, even if the Looper should normally
keep the thread alive.
You seem to be confused about the Looper's purpose/functionality. The Looper is keeping the thread alive. If the main thread was not kept alive, your application would exit. The Looper does not, however, provide repeated execution of the Runnables posted to the Handler/Thread which it is associated with. Each Runnable is executed exactly once. If you want to execute the same Runnable multiple times, you must post it multiple times. For example:
Handler mainThreadHandler = new Handler(Looper.getMainLooper());
Runnable doToast = new Runnable() {
#Override
public void run() {
Toast.makeText(menuActivity, "HELLO", Toast.LENGTH_SHORT).show();
}
});
mainThreadHandler.post(doToast); // Queue the first execution of the code in the Runnable's run() method.
mainThreadHandler.post(doToast); // Queue the second execution of the code in the Runnable's run() method.
Related
My code contains two buttons and a TextView. When the program is running, by clicking on the start Thread button, a background Thread will be executed and at the same time a counter will be displayed in the TextView, and when you click on the stop Thread button, the background Thread will stop. My question is that I have not used the looper here and the counter value is displayed from the background thread in the TextView on the UI thread. How is this possible?
activity_main.xml
<?xml version="1.0" encoding="utf-8"?>
<LinearLayout
xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:orientation="vertical"
android:gravity="center"
tools:context=".MainActivity">
<TextView
android:id="#+id/txtViewThreadCount"
android:hint="Thread Count"
android:textSize="30sp"
android:textColor="#color/black"
android:gravity="center"
android:padding="8dp"
android:layout_margin="10dp"
android:layout_width="match_parent"
android:layout_height="wrap_content"/>
<Button
android:id="#+id/btnStartThread"
android:layout_width="300dp"
android:layout_height="wrap_content"
android:textSize="30sp"
android:layout_marginTop="30dp"
android:text="Start Thread" />
<Button
android:id="#+id/btnStopThread"
android:layout_width="300dp"
android:layout_height="wrap_content"
android:textSize="30sp"
android:layout_marginTop="30dp"
android:text="Stop Thread" />
</LinearLayout>
MainActivity.java
public class MainActivity extends AppCompatActivity implements View.OnClickListener{
//Fields
private static final String TAG = MainActivity.class.getSimpleName();
private TextView txtViewThreadCount;
private Button btnStartThread, btnStopThread;
private boolean stopLoop;
private int count = 0;
#Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_main);
Log.e(TAG, "Thread id : "+Thread.currentThread().getId());
btnStartThread = findViewById(R.id.btnStartThread);
btnStopThread = findViewById(R.id.btnStopThread);
txtViewThreadCount = findViewById(R.id.txtViewThreadCount);
btnStartThread.setOnClickListener(this);
btnStopThread.setOnClickListener(this);
}
public void onClick(View view){
switch(view.getId()){
case R.id.btnStartThread:
stopLoop = true;
new Thread(new Runnable() {
#Override
public void run() {
while(stopLoop){
try {
Thread.sleep(1000);
count++;
} catch (InterruptedException e) {
Log.e(TAG,e.getMessage());
}
Log.e(TAG,"Thread id in while loop: "+Thread.currentThread().getId()+", Count: "+count);
txtViewThreadCount.setText(count+"");
}
}
}).start();
break;
case R.id.btnStopThread:
stopLoop = false;
break;
}
}
}
See Processes and threads overview in the Android docs:
Do not access the Android UI toolkit from outside the UI thread
It doesn't state what will happen if you ignore this rule; one of the possible outcomes is "it may sometimes work and then crash on your users' devices".
You can use runOnUiThread or View.post in this situation to do move the setText call back onto the UI thread.
See also What is the Android UiThread?.
When an application is launched, the system creates a thread of execution for the application, called "main." This thread is very important because it is in charge of dispatching events to the appropriate user interface widgets, including drawing events. It is also almost always the thread in which your application interacts with components from the Android UI toolkit (components from the android.widget and android.view packages).
Normally you could not update the UI in the work thread. You could use
1.Activity.runOnUiThread(Runnable)
2.View.post(Runnable)
to fix this issue.
Please see for detail
https://developer.android.com/guide/components/processes-and-threads#WorkerThreads
I want to toggle visibility of some elements. I have read some Q/A that the main problem was doing this in main thread but I am running the code in runOnUiThread but not works yet:
TextView progress;
TextView registrationFailed;
Button tryAgainRegistration;
#Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.registration);
sp = this.getSharedPreferences("settings", this.MODE_PRIVATE);
progress = (TextView) findViewById(R.id.progress);
registrationFailed = (TextView) findViewById(R.id.registrationFailed);
tryAgainRegistration=(Button) findViewById(R.id.tryAgainRegistration);
Setstat(0); // For test
}
public void Setstat(final Integer a){
runOnUiThread(new Runnable() {
#Override
public void run() {
Log.e("progress",a.toString()); // It shows 0 and 1 correctly
if (a == 1) {
progress.setVisibility(View.VISIBLE);
registrationFailed.setVisibility(View.GONE);
tryAgainRegistration.setVisibility(View.GONE);
} else {
progress.setVisibility(View.GONE);
registrationFailed.setVisibility(View.VISIBLE);
tryAgainRegistration.setVisibility(View.VISIBLE);
}
}
});
}
for more details this is the UI xml:
<TextView
android:id="#+id/progress"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:gravity="center_horizontal|center_vertical"
android:text="Registeration in progress"
android:visibility="visible" />
<TextView
android:id="#+id/registrationFailed"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:gravity="center_horizontal|center_vertical"
android:text="Registeration in progress"
android:visibility="gone" />
<Button
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_gravity="center_horizontal"
android:text="Try again"
android:id="#+id/tryAgainRegistration"
android:visibility="gone"
/>
Try running this in on create.
Just to see if it is because of the threads or not:
findViewById(R.id.yourView).setVisibility(View.GONE);
The runOnUiThread method needs a reference to the activity.
Otherwise it doesn't know which one the UI thread is.
You might get a warning about memory leaks. If you are worried about that, google for WeakReference.
((Activity)context).runOnUiThread(new Runnable() {
My specific problem was that I had created the XML view using constrainLayout but modified it manually without removing original settings of constrainLayout. So I guess the layout was not well recognized by system Ui.
In fact I made a mistake by manually renaming android.support.constraint.ConstraintLayout to LinearLayout as the root element.
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="match_parent"
app:layout_behavior="#string/appbar_scrolling_view_behavior"
tools:context=".Registration"
tools:showIn="#layout/activity_registration">
I have a dummy RelativelayoutView with progress bar.
<RelativeLayout
android:layout_width="match_parent"
android:layout_height="match_parent"
android:id="#+id/progressbar">
<ProgressBar
style="?android:attr/progressBarStyleLarge"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_centerVertical="true"
android:layout_centerHorizontal="true"
android:id="#+id/progressBar" />
</RelativeLayout>
When my app starts I need this RelativelayoutView to appear for 5 seconds and should diappear with or without animation.
I'm not sure I understood your question, but I'd suggest you to write something like this in your activity:
private Handler mHandler;
#Override
public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.your_layout);
mHandler = new Handler(Looper.getMainLooper());
mHandler.postDelayed(new Runnable() {
public void run() {
// hide your progress bar
findViewById(R.id.progressBar).setVisibility(View.GONE);
// or finish this activity and start a new one
startActivity(new Intent(MyActivity.this, MySecondActivity.class));
}
}, 5000);
}
#Override
public void onDestroy() {
super.onDestroy();
mHandler.removeCallbacks(null);
}
And I think you should add the android:indeterminate="true" attribute to your progress bar.
Hope it helps. Cheers.
I'm just learning Android and I'm already having trouble with complete basics:
I'd like to have a timer that increments a TextView but it crashes the first time the timer ticks.
Here's my code:
public class Game extends Activity {
Timer timer = new Timer();
int i = 0;
TextView text;
#Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_game);
text = (TextView) findViewById(R.id.timerText);
text.setText("0");
timer.schedule(new TimerTask() {
public void run() {
i++;
System.out.println(i);
text.setText(i + "");
if(i>100) timer.cancel();
}
}, 1000, 1000);
}
}
Here's my XML:
<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="match_parent"
android:layout_height="match_parent" >
...
<TextView
android:id="#+id/timerText"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_alignParentTop="true"
android:layout_centerHorizontal="true"
android:layout_marginTop="50dp"
android:text="Large Text"
android:textAppearance="?android:attr/textAppearanceLarge" />
</RelativeLayout>
I found a ton of solutions for setText crashing but none of them seemed to fix this.
You need to call text.setText(i + ""); from runOnUiThread()
Look at this : Android: Accessing UI Element from timer thread
Explantation : you've got error because you try accessing to UI element(in your case - textView) from separate background thread.
Also look this answer with simplifiest example: https://stackoverflow.com/a/6702767/2956344
if you are accesing to UI element in the timer run you should use a Handler or runOnUITheard.
Please check:
http://developer.android.com/reference/android/app/Activity.html#runOnUiThread(java.lang.Runnable)
and
Android: Accessing UI Element from timer thread
I have a ViewFlipper that shows 2 imageview (red one when disconnected and the green other when connected), however, i have a strange result: sometimes the red image is showen when i'm connected, it switches like this : red-green-and returns red(even when i'm connected).
Here is the JAVA code:
public void onRegistrationDone(String localProfileUri, long expiryTime) {
updateStatus("Enregistré au serveur.");
Log.d("SUCCEED","Registration DONE");
final ViewFlipper flipper = (ViewFlipper)findViewById(R.id.flipper);
flipper.postDelayed(new Runnable() {
public void run() {
flipper.showNext();
}
},2000);}
The view is initiated with the red image, then, when connected(and after 2 seconds) the next image is normally showen.
What could be the problem?
Thank you very much.
EDIT: XML file (Handler)
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:orientation="vertical" android:layout_width="fill_parent"
android:layout_height="fill_parent">
<TextView
android:id="#+id/sipLabel"
android:textSize="20sp"
android:layout_width="fill_parent"
android:layout_height="wrap_content"
/>
<ImageView android:id="#+id/status" android:layout_below="#id/sipLabel"
android:layout_width="fill_parent" android:scaleType="center"
android:layout_height="fill_parent" android:layout_weight="0.35" android:gravity="center"
/>
</LinearLayout>
I would do that differently. If that is just a matter of displaying different image (red/green) I would use ImageView UI control to display that image. And for the delayed display update you may use Handler. Something like this:
public void onRegistrationDone(String localProfileUri, long expiryTime)
{
updateStatus("Enregistré au serveur.");
Log.d("SUCCEED","Registration DONE");
mRegistered = true;
mRegistrationUpdateHandler.removeCallbacks(handleUpdateStatus);
mRegistrationUpdateHandler.postDelayed(handleUpdateStatus, 2000);
}
public void onRegistrationLost()
{
mRegistered = false;
mRegistrationUpdateHandler.removeCallbacks(handleUpdateStatus);
mRegistrationUpdateHandler.postDelayed(handleUpdateStatus, 2000);
}
private Runnable handleUpdateStatus = new Runnable()
{
public void run()
{
ImageView statusImageDisplay = (ImageView)findViewById(R.id.statusImage);
if (mRegistered)
{
statusImageDisplay.setImageDrawable(getResources().getDrawable(R.drawable.imageGreen));
else
{
statusImageDisplay.setImageDrawable(getResources().getDrawable(R.drawable.imageRed));
}
}
};