Develop Reference

Android studio app developing.Can somebody help me breakdown this part of my code.It's 100% where my error is

i'm tring to figure out where my app does not pass data.
Here is my login fragment
package com.example.progettoprogrammazione.intro
import android.content.Context
import android.content.Intent
import android.os.Bundle
import android.view.LayoutInflater
import android.view.View
import android.view.ViewGroup
import android.widget.Toast
import androidx.fragment.app.Fragment
import androidx.navigation.findNavController
import com.example.progettoprogrammazione.R
import com.example.progettoprogrammazione.activity.EmployeeActivity
import com.example.progettoprogrammazione.activity.UserActivity
import com.example.progettoprogrammazione.activity.RestaurateurActivity
import com.example.progettoprogrammazione.databinding.FragmentLoginBinding
import com.example.progettoprogrammazione.models.Dipendente
import com.example.progettoprogrammazione.models.Restaurant
import com.example.progettoprogrammazione.models.dipendenteList
import com.example.progettoprogrammazione.utils.*
import com.google.firebase.auth.FirebaseAuth
import com.google.firebase.database.DataSnapshot
import com.google.firebase.database.DatabaseError
import com.google.firebase.database.FirebaseDatabase
import com.google.firebase.database.ValueEventListener
class FragmentLogin : Fragment(), UserUtil,DipendenteUtil,RestaurantUtils {
private lateinit var binding: FragmentLoginBinding
override var firebaseAuth: FirebaseAuth = FirebaseAuth.getInstance()
override var firebaseDatabase: FirebaseDatabase = FirebaseDatabase.getInstance()
private lateinit var restArrayList: ArrayList<Restaurant>
private lateinit var dipArrayList: ArrayList<Dipendente>
private var userlvl: String? = null
override fun onCreateView(
inflater: LayoutInflater,
container: ViewGroup?,
savedInstanceState: Bundle?
): View? {
binding = FragmentLoginBinding.inflate(layoutInflater)
return binding.root
}
override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
super.onViewCreated(view, savedInstanceState)
firebaseAuth = FirebaseAuth.getInstance()
binding.ConstraintLogin.setOnClickListener() {
val email = binding.email.text.toString()
val password = binding.password.text.toString()
if (email.isNotEmpty() && password.isNotEmpty()) {
firebaseAuth.signInWithEmailAndPassword(email, password).addOnCompleteListener {
if (it.isSuccessful) {
//FUNZIONE CHE PRENDE DATI RISTORANTI
/*
FUNZIONE CHE PRENDE I DATI DI DIPENDENTE
dipArrayList = arrayListOf()
getDipendenteData(object : FireBaseCallbackDipendente {
override fun onResponse(response: ResponseDipendente) {
dipArrayList = response.dipendenti
}
}, context)
*/
//LOGIN
getUserData(object : FireBaseCallbackUser {
override fun onResponse(response: ResponseUser) {
userlvl = response.user!!.Livello
Toast.makeText(context,"Login effettuato con successo!", Toast.LENGTH_LONG).show()
when (userlvl) {
"1" -> {
getRestaurantData(object : FireBaseCallbackRestaurant {
override fun onResponse(responseR: ResponseRistorante) {
restArrayList = responseR.ristoranti
val args = Bundle()
args.putParcelableArrayList("listaRistoranti", restArrayList)
val intent =
Intent(context, UserActivity::class.java).apply {
putExtra("user", response.user)
putExtra("listaRistoranti", responseR.ristoranti)
}
startActivity(intent)
activity?.finish()
}
}, context)
}
"2" -> {
getRestaurantData(object : FireBaseCallbackRestaurant {
override fun onResponse(responseR: ResponseRistorante) {
restArrayList = arrayListOf()
restArrayList = responseR.ristoranti
val args = Bundle()
args.putParcelableArrayList("listaRistoranti", restArrayList)
val intent =
Intent(context, EmployeeActivity::class.java).apply {
putExtra("user", response.user)
putExtra("listaRistoranti", responseR.ristoranti)
}
startActivity(intent)
activity?.finish()
}
}, context)
}
"3" -> {
getRestaurantData(object : FireBaseCallbackRestaurant {
override fun onResponse(responseR: ResponseRistorante) {
restArrayList = arrayListOf()
restArrayList = responseR.ristoranti
val args = Bundle()
args.putParcelableArrayList("listaRistoranti", restArrayList)
//args.putSerializable("arraylist", restArrayList)
val intent =
Intent(context, RestaurateurActivity::class.java).apply {
putExtra("user", response.user)
putExtra("ristoranti", args)
}
startActivity(intent)
activity?.finish()
}
}, context)
}
else -> {
Toast.makeText(
context,
"Errore durante il caricamento.",
Toast.LENGTH_LONG
).show()
}
}
}
}, context)
} else Toast.makeText(
context,
"Email e password non corrispondono!",
Toast.LENGTH_LONG
).show()
}
} else {
Toast.makeText(context, "Nessun campo può essere vuoto!", Toast.LENGTH_LONG).show()
}
}
binding.noaccount.setOnClickListener {
view.findNavController().navigate(R.id.LoginToRegister)
}
}
}
I wanted to focus on this portion of code
getRestaurantData(object : FireBaseCallbackRestaurant {
override fun onResponse(responseR: ResponseRistorante) {
restArrayList = responseR.ristoranti
val args = Bundle()
args.putParcelableArrayList("listaRistoranti", restArrayList)
val intent =
Intent(context, UserActivity::class.java).apply {
putExtra("user", response.user)
putExtra("listaRistoranti", responseR.ristoranti)
}
startActivity(intent)
activity?.finish()
}
}, context)
}
Here it's my userActivity class
package com.example.progettoprogrammazione.activity
import android.content.Context
import android.content.Intent
import android.graphics.Rect
import android.os.Bundle
import android.view.MotionEvent
import android.view.View
import android.view.inputmethod.InputMethodManager
import android.widget.EditText
import android.widget.Toast
import androidx.appcompat.app.AppCompatActivity
import androidx.navigation.findNavController
import com.example.progettoprogrammazione.R
import com.example.progettoprogrammazione.databinding.ActivityUserBinding
import com.example.progettoprogrammazione.fragment.FragmentRistoranti
import com.example.progettoprogrammazione.models.Restaurant
import com.example.progettoprogrammazione.models.User
import com.google.firebase.auth.FirebaseAuth
class UserActivity : AppCompatActivity() {
private lateinit var binding: ActivityUserBinding
private lateinit var user: FirebaseAuth
private var pressedTime = 0L
override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
binding = ActivityUserBinding.inflate(layoutInflater)
setContentView(binding.root)
user = FirebaseAuth.getInstance()
val u = intent.getParcelableExtra("user") as User?
val bundleU = Bundle()
bundleU.putParcelable("user", u)
val r = intent.getParcelableArrayListExtra<Restaurant>("listaRistoranti") as ArrayList<Restaurant>?
val bundleR = Bundle()
bundleR.putParcelableArrayList("listaRistoranti", r)
binding.navbarUser.setOnNavigationItemSelectedListener {
when (it.itemId) {
R.id.ic_ristorantiU -> {
val navController = this.findNavController(R.id.user_nav)
navController.navigate(R.id.Ristoranti_U, bundleR)
}
R.id.ic_profileU -> {
val navController = this.findNavController(R.id.user_nav)
navController.navigate(R.id.Profilo_U, bundleU)
}
R.id.ic_logoutU -> {
user.signOut()
Toast.makeText(this, "Logout effettuato con successo", Toast.LENGTH_LONG).show()
val intent = Intent(this, IntroActivity::class.java)
startActivity(intent)
finish()
}
}
true
}
}
override fun onBackPressed() {
if (pressedTime + 2000 > System.currentTimeMillis()) {
super.onBackPressed()
finishAffinity()
} else {
Toast.makeText(baseContext, "Premi indietro di nuovo per uscire.", Toast.LENGTH_SHORT).show()
}
pressedTime = System.currentTimeMillis()
}
override fun dispatchTouchEvent(ev: MotionEvent?): Boolean {
if (ev?.action == MotionEvent.ACTION_UP) {
val v: View? = currentFocus
if (v is EditText) {
val outRect = Rect()
v.getGlobalVisibleRect(outRect)
if (!outRect.contains(ev.rawX.toInt(), ev.rawY.toInt())) {
v.clearFocus()
val imm: InputMethodManager =
getSystemService(Context.INPUT_METHOD_SERVICE) as InputMethodManager
imm.toggleSoftInput(InputMethodManager.HIDE_IMPLICIT_ONLY, 0)
}
}
}
return super.dispatchTouchEvent(ev)
}
}
In particular at this lines of code,cause I tried debbugging as you can see here , only to find out that I get null so I guess I'm not getting data from the intent (more in depth from
putExtra("listaRistoranti", responseR.ristoranti)
this line of code)
val r = intent.getParcelableArrayListExtra<Restaurant>("listaRistoranti") as ArrayList<Restaurant>?
val bundleR = Bundle()
bundleR.putParcelableArrayList("listaRistoranti", r)
can somebody help me and also explain what I did wrong

How to set the visibility GONE after the download was successful, and visibility still VISIBLE if download was unsuccessful?

I am making a studymaterial app, where i want to add a functionality where - when a user download a particular chapter from recyclerview and after the successful download of that item the Download button visivity should make GONE of that item at that time.
I have implemented a method to do thisd but it only works when user finish the activity and come back again on that activity then the download button automatic not showing, but i want to implement at that point of time when user download something.
Here is my DownloadHandler.kt class
package com.tworoot2.class9thhistoryncert.downloadHandler
import android.app.AlertDialog
import android.app.ProgressDialog
import android.content.Context
import android.content.Intent
import android.widget.Toast
import com.downloader.*
import com.tworoot2.class9thhistoryncert.DownloadedFiles
import java.io.File
import com.tworoot2.class9thhistoryncert.R
class DownloadHandler {
lateinit var alertDialog: AlertDialog.Builder
lateinit var failed: AlertDialog.Builder
var progressDialog: ProgressDialog? = null
var fileDestination: File? = null
var down: Boolean = false
fun downloadFile(url: String?, fileName: String, context: Context, filePath: File): Boolean {
progressDialog = ProgressDialog(context)
progressDialog!!.setMessage("Downloading....")
progressDialog!!.setCancelable(false)
progressDialog!!.max = 100
progressDialog!!.setProgressStyle(ProgressDialog.STYLE_SPINNER)
progressDialog!!.show()
alertDialog = AlertDialog.Builder(context)
alertDialog.setTitle("Downloaded successfully")
alertDialog.setMessage("$fileName is downloaded successfully")
alertDialog.setIcon(R.drawable.check)
alertDialog.setPositiveButton(
"Open"
) { _, i ->
val intent = Intent(context, DownloadedFiles::class.java)
context.startActivity(intent)
}
failed = AlertDialog.Builder(context)
failed.setTitle("Downloading failed")
failed.setMessage("Your file is not downloaded successfully")
failed.setIcon(R.drawable.failed)
PRDownloader.download(url, filePath.path, fileName)
.build()
.setOnStartOrResumeListener { }
.setOnPauseListener { }
.setOnCancelListener { }
.setOnProgressListener { progress ->
val per = progress.currentBytes * 100 / progress.totalBytes
progressDialog!!.setMessage("Downloading : $per %")
}
.start(object : OnDownloadListener {
override fun onDownloadComplete() {
down = true
Toast.makeText(context, "Download completed ", Toast.LENGTH_SHORT).show()
progressDialog!!.dismiss()
alertDialog.show()
}
override fun onError(error: Error) {
down = false
Toast.makeText(context, "Something went wrong", Toast.LENGTH_SHORT).show()
failed.show()
progressDialog!!.dismiss()
}
})
return down
}
}
Adapter Class
package com.tworoot2.class9thhistoryncert.adapters
import android.content.Context
import android.content.Intent
import android.view.LayoutInflater
import android.view.View
import android.view.ViewGroup
import android.widget.LinearLayout
import android.widget.TextView
import androidx.recyclerview.widget.RecyclerView
import com.tworoot2.class9thhistoryncert.Interface.OnPDFSelectListener
import com.tworoot2.class9thhistoryncert.Interface.PDFDownloadListner
import com.tworoot2.class9thhistoryncert.PDFActivity
import com.tworoot2.class9thhistoryncert.R
import com.tworoot2.class9thhistoryncert.models.StudyMaterials
import java.io.File
import java.lang.String
import kotlin.Int
class MaterialsAdapter(
var context: Context,
var arrayList: List<StudyMaterials>,
var listener: PDFDownloadListner,
var pdfSelectListener: OnPDFSelectListener,
var folderLocations: File
) :
RecyclerView.Adapter<MaterialsAdapter.ViewHolder>() {
override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): ViewHolder {
val view = LayoutInflater.from(parent.context)
.inflate(R.layout.custom_materials, parent, false)
return ViewHolder(view)
}
override fun onBindViewHolder(holder: ViewHolder, position: Int) {
holder.subjectHead.text = arrayList[position].chNo
holder.subjectName.text = arrayList[position].Title
val file =
File(
"$folderLocations/" + String.valueOf(
"Ch-" + arrayList[position].chNo + ". "
+ arrayList[position].Title + " [twoRoot2]" + ".pdf"
)
)
if (file.exists()) {
holder.downloadBtn.visibility = View.GONE
}
holder.itemView.setOnClickListener {
if (file.exists()) {
pdfSelectListener.onPDFSelected(file)
} else {
val intent = Intent(holder.itemView.context, PDFActivity::class.java)
intent.putExtra("link", arrayList[position].Link)
intent.putExtra("flag", "y")
intent.putExtra("title", arrayList[position].Title)
intent.putExtra("chNo", arrayList[position].chNo)
it.context.startActivity(intent)
}
}
holder.downloadBtn.setOnClickListener {
val downloaded = listener.onDownload(
arrayList[position].Link,
String.valueOf("Ch-" + arrayList[position].chNo)
.toString() + ". " + arrayList[position].Title
)
}
}
override fun getItemCount(): Int {
return arrayList.size
}
inner class ViewHolder(itemView: View) : RecyclerView.ViewHolder(itemView) {
val subjectName = itemView.findViewById<TextView>(R.id.subjectName);
val subjectHead = itemView.findViewById<TextView>(R.id.subjectHead);
val downloadBtn = itemView.findViewById<LinearLayout>(R.id.downloadBtn);
}
}
Activity Class
package com.tworoot2.class9thhistoryncert
import android.app.ProgressDialog
import android.content.Context
import android.content.Intent
import android.os.Bundle
import android.os.Environment
import android.view.MenuItem
import android.widget.Toast
import androidx.appcompat.app.AppCompatActivity
import androidx.lifecycle.ViewModelProvider
import androidx.recyclerview.widget.LinearLayoutManager
import androidx.recyclerview.widget.RecyclerView
import com.tworoot2.class9thhistoryncert.Interface.OnPDFSelectListener
import com.tworoot2.class9thhistoryncert.Interface.PDFDownloadListner
import com.tworoot2.class9thhistoryncert.adapters.MaterialsAdapter
import com.tworoot2.class9thhistoryncert.application.MyApplicationClass
import com.tworoot2.class9thhistoryncert.downloadHandler.DownloadHandler
import com.tworoot2.class9thhistoryncert.viewModels.MainViewModel
import com.tworoot2.class9thhistoryncert.viewModels.MainViewModelFactory
import com.tworoot2.result10th_12th.Internetconnection.NetworkUtils
import java.io.File
class MaterialsActivity : AppCompatActivity(), PDFDownloadListner, OnPDFSelectListener {
lateinit var recyclerView: RecyclerView
lateinit var mainViewModel: MainViewModel
lateinit var file: File
lateinit var fileDestination: File
lateinit var downloadHandler: DownloadHandler
override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
setContentView(R.layout.activity_materials)
supportActionBar!!.setDisplayHomeAsUpEnabled(true)
supportActionBar!!.setDisplayShowHomeEnabled(true)
recyclerView = findViewById(R.id.recView)
recyclerView.layoutManager = LinearLayoutManager(this)
// download listener
downloadHandler = DownloadHandler()
file = File(getExternalFilesDir(null).toString() + "/" + "Class")
fileDestination = File(Environment.getExternalStorageDirectory(), "/Class")
if (!fileDestination.exists()) {
fileDestination.mkdirs()
}
if (!NetworkUtils.isInternetAvailable(this#MaterialsActivity)) {
Toast.makeText(this#MaterialsActivity, "No internet connection", Toast.LENGTH_SHORT)
.show()
}
val progressDialog = ProgressDialog(this)
progressDialog.setMessage("Loading....")
progressDialog.setCancelable(false)
progressDialog.show()
val medium = intent.getStringExtra("medium")
val repository = (application as MyApplicationClass).materialsRepo
mainViewModel =
ViewModelProvider(this, MainViewModelFactory(repository))[MainViewModel::class.java]
if (medium.equals("h")) {
mainViewModel.hisHinLiveData.observe(this) {
this#MaterialsActivity.runOnUiThread(java.lang.Runnable {
val adapter =
MaterialsAdapter(
this#MaterialsActivity, it!!.studyMaterialCS,
this, this, file
)
progressDialog.dismiss()
recyclerView.adapter = adapter
})
}
} else if (medium.equals("e")) {
mainViewModel.hisEngLiveData.observe(this) {
this#MaterialsActivity.runOnUiThread(java.lang.Runnable {
val adapter =
MaterialsAdapter(
this#MaterialsActivity, it!!.studyMaterialCS,
this, this, file
)
progressDialog.dismiss()
recyclerView.adapter = adapter
})
}
} else {
Toast.makeText(this#MaterialsActivity, "Everything is invalid", Toast.LENGTH_SHORT)
.show()
}
}
override fun onOptionsItemSelected(item: MenuItem): Boolean {
when (item.itemId) {
android.R.id.home -> {
finish()
return true
}
}
return super.onOptionsItemSelected(item)
}
override fun onDownload(url: String?, title: String?) {
val time = System.currentTimeMillis().toString()
val shortTime = time.substring(8, 12)
val fileName = "$title [twoRoot2]"
// downloadFile(url, fileName + ".pdf");
// downloadFile(url, fileName + ".pdf");
Toast.makeText(applicationContext, "Downloading....", Toast.LENGTH_SHORT).show()
val downloaded =
downloadHandler.downloadFile(url, "$fileName.pdf", this#MaterialsActivity, file)
// Toast.makeText(applicationContext, "D...." + downloaded, Toast.LENGTH_SHORT).show()
}
override fun onPDFSelected(file: File?) {
val intent = Intent(this#MaterialsActivity, PDFActivity::class.java)
intent.putExtra("path", file!!.absolutePath)
intent.putExtra("flag", "n")
startActivity(intent)
}
override fun onDelete(file: File?, position: Int) {
TODO("Not yet implemented")
}
override fun inExternalApp(file: File?, context: Context?) {
TODO("Not yet implemented")
}
}
Repository Class
package com.tworoot2.class9thhistoryncert.repository
import android.content.Context
import android.util.Log
import androidx.lifecycle.LiveData
import androidx.lifecycle.MutableLiveData
import com.tworoot2.class9thhistoryncert.api.MaterialsService
import com.tworoot2.class9thhistoryncert.models.MaterialsElist
import com.tworoot2.class9thhistoryncert.models.MaterialsList
import com.tworoot2.result10th_12th.Internetconnection.NetworkUtils
class MaterialsRepo(private val service: MaterialsService, private val context: Context) {
private val hisHinMutableLiveData = MutableLiveData<MaterialsList>()
private val hisEngMutableLiveData = MutableLiveData<MaterialsList>()
val hisHinLiveData: LiveData<MaterialsList>
get() = hisHinMutableLiveData
val hisEngLiveData: LiveData<MaterialsList>
get() = hisEngMutableLiveData
suspend fun getHisHindi() {
if (NetworkUtils.isInternetAvailable(context)) {
val result = service.getHistoryHindiFromAPI()
if (result.body() != null) {
hisHinMutableLiveData.postValue(result.body())
}
} else {
Log.e("InternetError", "No Internet Connection")
}
}
suspend fun getHisEnglish() {
if (NetworkUtils.isInternetAvailable(context)) {
val result = service.getHistoryEnglishFromAPI()
if (result.body() != null) {
hisEngMutableLiveData.postValue(result.body())
}
}else{
Log.e("InternetError", "No Internet Connection")
}
}
}
[Screen Shot 1]
[Screen Shot 2]

Maybe you want to use LiveData to handle realtime update UI for your case. After download thread run completed, let observer call update item in recyclerview.
Hope it help!

Items are not removing from the recycler view

I am building a function in my android app in which user will match two items together
and if both items match to each other a correct icon will display to the item where u clicked to match,and if ur match was wrong then it show u the wrong icon.
There is condition when the match is correct then the both correct items are removed i try various ways to removed but they are not seems perfect.
The matching are based on the languages its a langauge translation app suppose u try to translate the How are u(engilsh) ->to ->Comment vas-tu(french) in that case if those count values are match that mean they are belong to each other so its right
The value of count I provided from the activity where i adding values to the matchdataholder,By the loop count variable saved the ist lang (english text) at count 1 and 2nd language(french) to count 1 as well but with differnt index
Activity Class
package com.blablacards.activity
import android.os.Bundle
import android.view.View
import android.widget.Toast
import androidx.recyclerview.widget.GridLayoutManager
import com.blablacards.R
import com.blablacards.adapter.MatchAdapter
import com.blablacards.app.retrofit.ApiCall
import com.blablacards.model.FavListItem
import com.blablacards.model.MatchDataHolder
import com.blablacards.model.MatchList
import com.blablacards.model.ResponseFavList
import com.blablacards.utils.AppPref
import com.blablacards.utils.Constants
import kotlinx.android.synthetic.main.activity_match.*
import retrofit2.Call
import retrofit2.Callback
import retrofit2.Response
class MatchActivity : BaseActivity(), View.OnClickListener {
var matchDataHolder: ArrayList<MatchDataHolder>? = ArrayList<MatchDataHolder>()
var favWordList = ArrayList<FavListItem>()
var matchList = ArrayList<MatchList>()
var categoryId: Int? = null
var categoryName: String? = null
lateinit var matchAdapter: MatchAdapter
override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
setContentView(R.layout.activity_match)
img_back.setOnClickListener(this)
getBundleData()
tv_header.text = categoryName
favWordList.clear()
calFavCategoryListApi("DESC")
// setAdapter()
}
private fun setAdapter(favWordList: ArrayList<MatchDataHolder>) {
Toast.makeText(this#MatchActivity, "Adapter called", Toast.LENGTH_SHORT).show()
matchAdapter = MatchAdapter(
this#MatchActivity,
favWordList
)
println("FAV LIST SIZE ->" + favWordList.size)
rv_match.layoutManager = GridLayoutManager(this#MatchActivity, 2)
rv_match.adapter = matchAdapter
}
private fun getBundleData() {
val extras = intent.extras
if (extras != null) {
categoryId = extras.getInt("CategoryId")
categoryName = extras.getString("CategoryName")
println("!!!categoryId = ${categoryId}")
}
}
private fun calFavCategoryListApi(sortBy: String) {
ApiCall.initApiCall(Constants.BASE_URL).getFavcategoryList(
"Bearer" + AppPref.getValue(AppPref.TOKEN, ""),
AppPref.getValue(AppPref.LOGIN_ID, "")!!, categoryId.toString(), "", "", sortBy
).enqueue(object : Callback<ResponseFavList> {
override fun onResponse(
call: Call<ResponseFavList>,
response: Response<ResponseFavList>
) {
if (response.isSuccessful) {
if (response.body()!!.status!!) {
favWordList.addAll(response.body()!!.data!!)
//
for (i in 0 until favWordList.size) {
matchDataHolder!!.add(MatchDataHolder(favWordList[i].sended_text.toString(),i))
matchDataHolder!!.add(MatchDataHolder(favWordList[i].return_text.toString(),i))
}
for(i in 0 until matchDataHolder!!.size){
println("DATA HOLDER ->"+ matchDataHolder!![i].text)
println("DATA HOLDER Count->"+ matchDataHolder!![i].count)
}
//
setAdapter(matchDataHolder!!)
} else {
showSnackBar(response.message())
}
}
}
override fun onFailure(call: Call<ResponseFavList>, t: Throwable) {
println("!!!t.message = ${t.message}")
}
})
}
override fun onClick(v: View?) {
when (v!!.id) {
R.id.img_back -> {
onBackPressed()
}
}
}
}
Adapter Class
package com.blablacards.adapter
import android.content.Context
import android.os.Handler
import android.view.LayoutInflater
import android.view.View
import android.view.ViewGroup
import android.widget.TextView
import android.widget.Toast
import androidx.recyclerview.widget.RecyclerView
import com.blablacards.R
import com.blablacards.model.MatchDataHolder
import kotlinx.android.synthetic.main.row_match.view.*
class MatchAdapter(
var context: Context,
var favWordList: ArrayList<MatchDataHolder>,
) : RecyclerView.Adapter<RecyclerView.ViewHolder>() {
var index1 = -1
var index2 = -1
var enabledFlag = false
var oldPos = -1
var newPos = -1
override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): RecyclerView.ViewHolder {
return ViewHolder(
LayoutInflater.from(context)
.inflate(R.layout.row_match, parent, false)
)
}
override fun onBindViewHolder(holder: RecyclerView.ViewHolder, position: Int) {
(holder as MatchAdapter.ViewHolder).bind(position)
holder.itemView.rl_match.setBackgroundColor(context.resources.getColor(R.color.white))
holder.itemView.tv_match.visibility = View.VISIBLE
holder.itemView.rl_match.setOnClickListener(View.OnClickListener {
if (!enabledFlag) {
println(enabledFlag)
println("IF block")
it.rl_match.setBackgroundColor(context.resources.getColor(R.color.orange_light3))
holder.itemView.tv_match.visibility = View.INVISIBLE
oldPos = favWordList[position].count
println("OLD POS ->" + oldPos)
index1 = position
println("index 1 = " + index1)
enabledFlag = true
} else {
// show the correct and wrong //
println("ELSE BLOCK")
enabledFlag = false
newPos = favWordList[position].count
println("NEW POS ->" + newPos)
index2 = position
println("index 2 = " + index2)
showCorrectOrFalse(holder.itemView, favWordList[position].count)
}
})
}
override fun getItemCount(): Int {
return favWordList.size
}
private fun timeHandler(itemView: View, status: String, position: Int) {
Handler().postDelayed({
if (status == "right") {
println("inside right")
itemView.tv_match.visibility = View.VISIBLE
itemView.rl_match.setBackgroundColor(context.resources.getColor(R.color.white))
itemView.img_right_or_wrong.visibility = View.INVISIBLE
// favWordList.drop(index1)
// favWordList.drop(index2)
/// THE PROBLEM IS HERE CUZ I'm not able to perfectly removed the item//
favWordList.remove(MatchDataHolder(favWordList[index1].text,newPos))
favWordList.remove(MatchDataHolder(favWordList[index2].text,oldPos))
notifyItemRemoved(index1)
notifyItemRemoved(index2)
notifyItemRangeChanged(index1,favWordList.size)
notifyItemRangeChanged(index2,favWordList.size)
notifyDataSetChanged()
}
if (status == "wrong") {
println("Inside wrong")
itemView.tv_match.visibility = View.VISIBLE
itemView.rl_match.setBackgroundColor(context.resources.getColor(R.color.white))
itemView.img_right_or_wrong.visibility = View.INVISIBLE
notifyDataSetChanged()
}
}, 2000)
}
private fun showCorrectOrFalse(itemView: View, position: Int) {
println("SHOW CORRECT CALLED")
//call handler after click //
println("OLD POS " + oldPos + " New POS " + newPos)
if (oldPos == newPos) {
itemView.img_right_or_wrong.setImageDrawable(context.resources.getDrawable(R.drawable.right_game))
Toast.makeText(context, "true", Toast.LENGTH_SHORT).show()
timeHandler(itemView, "right", position)
} else {
itemView.img_right_or_wrong.setImageDrawable(context.resources.getDrawable(R.drawable.wrong_game))
timeHandler(itemView, "wrong", position)
}
}
internal inner class ViewHolder(view: View) : RecyclerView.ViewHolder(view) {
fun bind(position: Int) {
itemView.findViewById<TextView>(R.id.tv_match).text =
favWordList[position].text
}
}
}
A model class for hold the data of item
class MatchDataHolder(text:String,num:Int) {
var count = num
var text =text
}

favWordList.remove(MatchDataHolder(favWordList[index1].text,newPos))
you remove a new MatchDataHolder which is not exist in favWordList
you can try this:
favWordList.removeAt(index1)

Profile Pic not displaying on Card View in Andorid Studio Kotlin

I am trying to get a users profile pic to be displayed beside their booking on a card in my recyclerview. The profile pic is displaying in my nav drawer, a default one for non-google users, or the profile pic of the Google user. However imageUri appears empty when I call it and the images are not being stored in my firebase storage bucket. I have linked my firebase and implemented the relevant SDK.
Here is my model.
#Parcelize
data class BookModel(
// var id : Long = 0,
var uid: String? = "",
var name: String = "N/A",
var phoneNumber: String = "N/A",
var email: String? = "N/A",
var date: String = "",
var bike: Int = 0,
var profilepic: String = "",
/*var lat: Double = 0.0,
var longitude: Double = 0.0,
var zoom: Float = 0f,*/
var pickup: String = "",
var dropoff: String = "",
var price: Double = 20.0,
/*var amount: Int = 0*/
) : Parcelable
{
#Exclude
fun toMap(): Map<String, Any?> {
return mapOf(
// "id" to id,
"uid" to uid,
"name" to name,
"phoneNumber" to phoneNumber,
"email" to email,
"date" to date,
"bike" to bike,
"profilepic" to profilepic,
"pickup" to pickup,
"dropoff" to dropoff,
"price" to price
)
}
}
#Parcelize
data class Location(
var lat: Double = 0.0,
var longitude: Double = 0.0,
var zoom: Float = 0f,
var depot: String = "Waterford"
) : Parcelable
Here is my FirebaseImageManager
package com.wit.mad2bikeshop.firebase
import android.graphics.Bitmap
import android.graphics.drawable.Drawable
import android.net.Uri
import android.widget.ImageView
import androidx.lifecycle.MutableLiveData
import com.google.firebase.storage.FirebaseStorage
import com.google.firebase.storage.UploadTask
import com.squareup.picasso.MemoryPolicy
import com.squareup.picasso.Picasso
import com.wit.mad2bikeshop.utils.customTransformation
import timber.log.Timber
import java.io.ByteArrayOutputStream
import com.squareup.picasso.Target
object FirebaseImageManager {
var storage = FirebaseStorage.getInstance().reference
var imageUri = MutableLiveData<Uri>()
fun checkStorageForExistingProfilePic(userid: String) {
val imageRef = storage.child("photos").child("${userid}.jpg")
val defaultImageRef = storage.child("ic_book_nav_header.png")
imageRef.metadata.addOnSuccessListener { //File Exists
imageRef.downloadUrl.addOnCompleteListener { task ->
imageUri.value = task.result!!
}
//File Doesn't Exist
}.addOnFailureListener {
imageUri.value = Uri.EMPTY
}
}
fun uploadImageToFirebase(userid: String, bitmap: Bitmap, updating : Boolean) {
// Get the data from an ImageView as bytes
val imageRef = storage.child("photos").child("${userid}.jpg")
//val bitmap = (imageView as BitmapDrawable).bitmap
val baos = ByteArrayOutputStream()
lateinit var uploadTask: UploadTask
bitmap.compress(Bitmap.CompressFormat.JPEG, 100, baos)
val data = baos.toByteArray()
imageRef.metadata.addOnSuccessListener { //File Exists
if(updating) // Update existing Image
{
uploadTask = imageRef.putBytes(data)
uploadTask.addOnSuccessListener { ut ->
ut.metadata!!.reference!!.downloadUrl.addOnCompleteListener { task ->
imageUri.value = task.result!!
}
}
}
}.addOnFailureListener { //File Doesn't Exist
uploadTask = imageRef.putBytes(data)
uploadTask.addOnSuccessListener { ut ->
ut.metadata!!.reference!!.downloadUrl.addOnCompleteListener { task ->
imageUri.value = task.result!!
}
}
}
}
fun updateUserImage(userid: String, imageUri : Uri?, imageView: ImageView, updating : Boolean) {
Picasso.get().load(imageUri)
.resize(200, 200)
.transform(customTransformation())
.memoryPolicy(MemoryPolicy.NO_CACHE)
.centerCrop()
.into(object : Target {
override fun onBitmapLoaded(bitmap: Bitmap?,
from: Picasso.LoadedFrom?
) {
Timber.i("DX onBitmapLoaded $bitmap")
uploadImageToFirebase(userid, bitmap!!,updating)
imageView.setImageBitmap(bitmap)
}
override fun onBitmapFailed(e: java.lang.Exception?,
errorDrawable: Drawable?) {
Timber.i("DX onBitmapFailed $e")
}
override fun onPrepareLoad(placeHolderDrawable: Drawable?) {}
})
}
fun updateDefaultImage(userid: String, resource: Int, imageView: ImageView) {
Picasso.get().load(resource)
.into(object : Target {
override fun onBitmapLoaded(bitmap: Bitmap?,
from: Picasso.LoadedFrom?
) {
Timber.i("DX onBitmapLoaded $bitmap")
uploadImageToFirebase(userid, bitmap!!,false)
imageView.setImageBitmap(bitmap)
}
override fun onBitmapFailed(e: java.lang.Exception?,
errorDrawable: Drawable?) {
Timber.i("DX onBitmapFailed $e")
}
override fun onPrepareLoad(placeHolderDrawable: Drawable?) {}
})
}
}
My FirebaseAuthManager...
package com.wit.mad2bikeshop.firebase
import android.app.Application
import androidx.lifecycle.MutableLiveData
import com.google.android.gms.auth.api.signin.GoogleSignIn
import com.google.android.gms.auth.api.signin.GoogleSignInAccount
import com.google.android.gms.auth.api.signin.GoogleSignInClient
import com.google.android.gms.auth.api.signin.GoogleSignInOptions
import com.google.firebase.auth.FirebaseAuth
import com.google.firebase.auth.FirebaseUser
import com.google.firebase.auth.GoogleAuthProvider
import com.wit.mad2bikeshop.R
import timber.log.Timber
class FirebaseAuthManager(application: Application) {
private var application: Application? = null
var firebaseAuth: FirebaseAuth? = null
var liveFirebaseUser = MutableLiveData<FirebaseUser>()
var loggedOut = MutableLiveData<Boolean>()
var errorStatus = MutableLiveData<Boolean>()
var googleSignInClient = MutableLiveData<GoogleSignInClient>()
init {
this.application = application
firebaseAuth = FirebaseAuth.getInstance()
if (firebaseAuth!!.currentUser != null) {
liveFirebaseUser.postValue(firebaseAuth!!.currentUser)
loggedOut.postValue(false)
errorStatus.postValue(false)
FirebaseImageManager.checkStorageForExistingProfilePic(
firebaseAuth!!.currentUser!!.uid)
}
configureGoogleSignIn()
}
fun login(email: String?, password: String?) {
firebaseAuth!!.signInWithEmailAndPassword(email!!, password!!)
.addOnCompleteListener(application!!.mainExecutor, { task ->
if (task.isSuccessful) {
liveFirebaseUser.postValue(firebaseAuth!!.currentUser)
errorStatus.postValue(false)
} else {
Timber.i("Login Failure: $task.exception!!.message")
errorStatus.postValue(true)
}
})
}
fun register(email: String?, password: String?) {
firebaseAuth!!.createUserWithEmailAndPassword(email!!, password!!)
.addOnCompleteListener(application!!.mainExecutor, { task ->
if (task.isSuccessful) {
liveFirebaseUser.postValue(firebaseAuth!!.currentUser)
errorStatus.postValue(false)
} else {
Timber.i("Registration Failure: $task.exception!!.message")
errorStatus.postValue(true)
}
})
}
fun logOut() {
firebaseAuth!!.signOut()
Timber.i( "firebaseAuth Signed out")
googleSignInClient.value!!.signOut()
Timber.i( "googleSignInClient Signed out")
loggedOut.postValue(true)
errorStatus.postValue(false)
}
private fun configureGoogleSignIn() {
val gso = GoogleSignInOptions.Builder(GoogleSignInOptions.DEFAULT_SIGN_IN)
.requestIdToken(application!!.getString(R.string.default_web_client_id))
.requestEmail()
.build()
googleSignInClient.value = GoogleSignIn.getClient(application!!.applicationContext,gso)
}
fun firebaseAuthWithGoogle(acct: GoogleSignInAccount) {
Timber.i( "DonationX firebaseAuthWithGoogle:" + acct.id!!)
val credential = GoogleAuthProvider.getCredential(acct.idToken, null)
firebaseAuth!!.signInWithCredential(credential)
.addOnCompleteListener(application!!.mainExecutor) { task ->
if (task.isSuccessful) {
// Sign in success, update with the signed-in user's information
Timber.i( "signInWithCredential:success")
liveFirebaseUser.postValue(firebaseAuth!!.currentUser)
} else {
// If sign in fails, display a message to the user.
Timber.i( "signInWithCredential:failure $task.exception")
errorStatus.postValue(true)
}
}
}
}
My Home activity
package com.wit.mad2bikeshop.ui.home
import android.content.Intent
import android.net.Uri
import android.os.Bundle
import android.view.MenuItem
import android.view.View
import androidx.appcompat.app.AppCompatActivity
import androidx.appcompat.widget.Toolbar
import androidx.drawerlayout.widget.DrawerLayout
import androidx.lifecycle.Observer
import androidx.lifecycle.ViewModelProvider
import androidx.navigation.findNavController
import androidx.navigation.fragment.NavHostFragment
import androidx.navigation.ui.*
import com.google.firebase.auth.FirebaseUser
import com.squareup.picasso.Picasso
import com.wit.mad2bikeshop.R
import com.wit.mad2bikeshop.databinding.HomeBinding
import com.wit.mad2bikeshop.databinding.NavHeaderBinding
import com.wit.mad2bikeshop.firebase.FirebaseImageManager
import com.wit.mad2bikeshop.ui.auth.LoggedInViewModel
import com.wit.mad2bikeshop.ui.auth.Login
import com.wit.mad2bikeshop.utils.customTransformation
import timber.log.Timber
class Home : AppCompatActivity() {
private lateinit var drawerLayout: DrawerLayout
private lateinit var homeBinding: HomeBinding
private lateinit var navHeaderBinding: NavHeaderBinding
private lateinit var appBarConfiguration: AppBarConfiguration
private lateinit var loggedInViewModel: LoggedInViewModel
private lateinit var headerView : View
override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
homeBinding = HomeBinding.inflate(layoutInflater)
setContentView(homeBinding.root)
drawerLayout = homeBinding.drawerLayout
val toolbar = findViewById<Toolbar>(R.id.toolbar)
setSupportActionBar(toolbar)
val navHostFragment =
supportFragmentManager.findFragmentById(R.id.nav_host_fragment) as NavHostFragment
val navController = navHostFragment.navController
// Passing each menu ID as a set of Ids because each
// menu should be considered as top level destinations.
appBarConfiguration = AppBarConfiguration(
setOf(
R.id.bookFragment, R.id.bookingListFragment
), drawerLayout
)
setupActionBarWithNavController(navController, appBarConfiguration)
val navView = homeBinding.navView
navView.setupWithNavController(navController)
initNavHeader()
}
public override fun onStart() {
super.onStart()
loggedInViewModel = ViewModelProvider(this).get(LoggedInViewModel::class.java)
loggedInViewModel.liveFirebaseUser.observe(this, Observer { firebaseUser ->
if (firebaseUser != null)
updateNavHeader(firebaseUser)
})
loggedInViewModel.loggedOut.observe(this, Observer { loggedout ->
if (loggedout) {
startActivity(Intent(this, Login::class.java))
}
})
}
private fun initNavHeader() {
Timber.i("DX Init Nav Header")
headerView = homeBinding.navView.getHeaderView(0)
navHeaderBinding = NavHeaderBinding.bind(headerView)
}
private fun updateNavHeader(currentUser: FirebaseUser) {
FirebaseImageManager.imageUri.observe(this, { result ->
if(result == Uri.EMPTY) {
Timber.i("DX NO Existing imageUri")
if (currentUser.photoUrl != null) {
//if you're a google user
FirebaseImageManager.updateUserImage(
currentUser.uid,
currentUser.photoUrl,
navHeaderBinding.navHeaderImage,
false)
}
else
{
Timber.i("DX Loading Existing Default imageUri")
FirebaseImageManager.updateDefaultImage(
currentUser.uid,
R.drawable.ic_book_nav_header,
navHeaderBinding.navHeaderImage)
}
}
else // load existing image from firebase
{
Timber.i("DX Loading Existing imageUri")
FirebaseImageManager.updateUserImage(
currentUser.uid,
FirebaseImageManager.imageUri.value,
navHeaderBinding.navHeaderImage, false)
}
})
navHeaderBinding.navHeaderEmail.text = currentUser.email
if(currentUser.displayName != null)
navHeaderBinding.navHeaderName.text = currentUser.displayName
}
override fun onSupportNavigateUp(): Boolean {
val navController = findNavController(R.id.nav_host_fragment)
return navController.navigateUp(appBarConfiguration) || super.onSupportNavigateUp()
}
fun signOut(item: MenuItem) {
loggedInViewModel.logOut()
//Launch Login activity and clear the back stack to stop navigating back to the Home activity
val intent = Intent(this, Login::class.java)
intent.addFlags(Intent.FLAG_ACTIVITY_CLEAR_TASK or Intent.FLAG_ACTIVITY_NEW_TASK)
startActivity(intent)
}
}
My BookViewModel
package com.wit.mad2bikeshop.ui.book
import androidx.lifecycle.LiveData
import androidx.lifecycle.MutableLiveData
import androidx.lifecycle.ViewModel
import com.google.firebase.auth.FirebaseUser
import com.wit.mad2bikeshop.firebase.FirebaseDBManager
import com.wit.mad2bikeshop.firebase.FirebaseImageManager
import com.wit.mad2bikeshop.model.BookManager
import com.wit.mad2bikeshop.model.BookModel
class BookViewModel : ViewModel() {
private val status = MutableLiveData<Boolean>()
val observableStatus: LiveData<Boolean>
get() = status
fun addBook(firebaseUser: MutableLiveData<FirebaseUser>,
booking: BookModel) {
status.value = try {
booking.profilepic = FirebaseImageManager.imageUri.value.toString()
FirebaseDBManager.create(firebaseUser,booking)
true
} catch (e: IllegalArgumentException) {
false
}
}
// fun updateBook(booking: BookModel){
// status.value = try {
// BookManager.update(booking)
// true
// } catch (e: IllegalArgumentException) {
// false
// }
// }
}
My BookAdapter
package com.wit.mad2bikeshop.adapters
import android.view.LayoutInflater
import android.view.ViewGroup
import androidx.core.net.toUri
import androidx.recyclerview.widget.RecyclerView
import com.squareup.picasso.MemoryPolicy
import com.squareup.picasso.Picasso
import com.wit.mad2bikeshop.R
import com.wit.mad2bikeshop.databinding.CardBookBinding
import com.wit.mad2bikeshop.model.BookModel
import com.wit.mad2bikeshop.utils.customTransformation
interface BookListener {
// fun onDeleteBooking(booking: BookModel)
// fun onUpdateBooking(booking: BookModel)
fun onBookingClick(booking: BookModel)
}
class BookAdapter constructor(
private var bookings: ArrayList<BookModel>,
private val listener: BookListener,
private val readOnly: Boolean)
: RecyclerView.Adapter<BookAdapter.MainHolder>() {
override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): MainHolder {
val binding = CardBookBinding
.inflate(LayoutInflater.from(parent.context), parent, false)
return MainHolder(binding, readOnly)
}
override fun onBindViewHolder(holder: MainHolder, position: Int) {
val booking = bookings[holder.adapterPosition]
holder.bind(booking, listener)
}
fun removeAt(position: Int) {
bookings.removeAt(position)
notifyItemRemoved(position)
}
override fun getItemCount(): Int = bookings.size
inner class MainHolder(val binding: CardBookBinding,private val readOnly : Boolean) :
RecyclerView.ViewHolder(binding.root) {
val readOnlyRow = readOnly
fun bind(booking: BookModel, listener: BookListener) {
binding.root.tag = booking
binding.booking = booking
binding.imageIcon.setImageResource(R.mipmap.ic_launcher_round)
Picasso.get().load(booking.profilepic.toUri())
.resize(200, 200)
.transform(customTransformation())
.centerCrop()
.into(binding.imageIcon)
//
// binding.name.text = booking.name
// binding.phoneNumber.text = booking.phoneNumber
// binding.date.text = booking.date
binding.root.setOnClickListener { listener.onBookingClick(booking) }
// binding.buttonDelete.setOnClickListener { listener.onDeleteBooking(booking) }
// binding.buttonUpdate.setOnClickListener { listener.onUpdateBooking(booking) }
binding.executePendingBindings()
/* binding.imageIcon.setImageResource(R.mipmap.ic_launcher_round)*/
}
}
}
I believe the problem stems from the (FirebaseImageManager.imageUri.value.toString()) on my BookAdapter, as if I run a Timber.I statement it doesn't return anything at all. If I run Timber.i(FirebaseImageManager.imageUri.value.toString()+ "test"), it only returns test.
Here is a link to the full project https://github.com/foxxxxxxx7/MAD2bikeshop
Apologies if I wasn't clear enough, I am a novice.

I figured it out, I had to modify my rules on the firebase storage.

second viewModel unable to construct

I have a problem building a second viewModel for my app.
In my project, the first viewModel observes a list of Contact, while the second viewModel observes a single contact.
Both viewModels are really similar, but the first builds, while the second cannot construct
E/AndroidRuntime: FATAL EXCEPTION: main
Process: fr.dleurs.android.contactapp, PID: 12324
java.lang.RuntimeException: Unable to start activity ComponentInfo{fr.dleurs.android.contactapp/fr.dleurs.android.contactapp.ui.detailsContact.DetailsContactActivity}: java.lang.IllegalArgumentException: Unable to construct viewmodel
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3449)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3601)
at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:85)
at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2066)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loop(Looper.java:223)
at android.app.ActivityThread.main(ActivityThread.java:7656)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)
Caused by: java.lang.IllegalArgumentException: Unable to construct viewmodel
at fr.dleurs.android.contactapp.viewmodel.ContactViewModel$Factory.create(ContactViewModel.kt:33)
at androidx.lifecycle.ViewModelProvider.get(ViewModelProvider.java:187)
at androidx.lifecycle.ViewModelProvider.get(ViewModelProvider.java:150)
at fr.dleurs.android.contactapp.ui.detailsContact.DetailsContactActivity.onCreate(DetailsContactActivity.kt:40)
at android.app.Activity.performCreate(Activity.java:8000)
at android.app.Activity.performCreate(Activity.java:7984)
at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1309)
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3422)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3601) 
at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:85) 
at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135) 
at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95) 
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2066) 
at android.os.Handler.dispatchMessage(Handler.java:106) 
at android.os.Looper.loop(Looper.java:223) 
at android.app.ActivityThread.main(ActivityThread.java:7656) 
at java.lang.reflect.Method.invoke(Native Method) 
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592) 
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947) 
I/Process: Sending signal. PID: 12324 SIG: 9
The second viewModel : ContactViewModel.kt
package fr.dleurs.android.contactapp.viewmodel
import android.app.Application
import androidx.lifecycle.*
import fr.dleurs.android.contactapp.database.ContactDatabase
import fr.dleurs.android.contactapp.database.ContactsDatabase.Companion.getInstance
import fr.dleurs.android.contactapp.model.Contact
import fr.dleurs.android.contactapp.repository.ContactRepository
import kotlinx.coroutines.launch
class ContactViewModel(application: Application) : AndroidViewModel(application) {
private val contactsRepository = ContactRepository(getInstance(application).contactDtbDao())
fun liveContact(contactId: String): LiveData<Contact> = contactsRepository.contact(contactId)
public fun updateContact(contact: ContactDatabase) {
viewModelScope.launch {
contactsRepository.updateContact(contact);
}
}
public fun deleteContact(contactId: String) {
viewModelScope.launch {
contactsRepository.deleteContact(contactId);
}
}
class Factory(val app: Application) : ViewModelProvider.Factory {
override fun <T : ViewModel?> create(modelClass: Class<T>): T {
if (modelClass.isAssignableFrom(ContactsViewModel::class.java)) {
#Suppress("UNCHECKED_CAST")
return ContactViewModel(app) as T
}
throw IllegalArgumentException("Unable to construct viewmodel")
}
}
}
The second activity, DetailsContactActivity.kt
package fr.dleurs.android.contactapp.ui.detailsContact
import android.app.Activity
import android.content.Intent
import android.os.Bundle
import android.widget.ImageButton
import androidx.appcompat.app.AppCompatActivity
import androidx.databinding.DataBindingUtil
import androidx.lifecycle.Observer
import androidx.lifecycle.ViewModelProvider
import androidx.lifecycle.lifecycleScope
import fr.dleurs.android.contactapp.R
import fr.dleurs.android.contactapp.database.ContactDatabase
import fr.dleurs.android.contactapp.databinding.DetailsContactActivityBinding
import fr.dleurs.android.contactapp.model.Contact
import fr.dleurs.android.contactapp.model.asDatabaseModel
import fr.dleurs.android.contactapp.ui.main.createContactActivityRequestCode
import fr.dleurs.android.contactapp.ui.main.detailContactActivityRequestCode
import fr.dleurs.android.contactapp.ui.newModifyContact.CreateModifyContactActivity
import fr.dleurs.android.contactapp.viewmodel.ContactViewModel
import fr.dleurs.android.contactapp.viewmodel.ContactsViewModel
import timber.log.Timber
class DetailsContactActivity : AppCompatActivity() {
private lateinit var binding: DetailsContactActivityBinding
private lateinit var contactId: String
private lateinit var viewModel: ContactViewModel
override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
contactId = intent?.getStringExtra("contactId") ?: ""
assert(!contactId.isNullOrEmpty())
viewModel = ViewModelProvider(
this,
ContactViewModel.Factory(this.application)
).get(ContactViewModel::class.java)
val buttonEdit = findViewById<ImageButton>(R.id.ibEdit)
val buttonDelete = findViewById<ImageButton>(R.id.ibDelete)
val buttonBack = findViewById<ImageButton>(R.id.ibBack)
binding = DataBindingUtil.setContentView(this, R.layout.details_contact_activity)
viewModel.liveContact(contactId).observe(this, Observer<Contact> { theContact -> // this or viewLifecycleOwner ?
theContact?.let {
binding.apply { contact = it }
}
})
buttonEdit.setOnClickListener {
val editIntent = Intent(this, CreateModifyContactActivity::class.java)
//editIntent.putExtra("contact", it)
startActivityForResult(editIntent, createContactActivityRequestCode)
}
buttonDelete.setOnClickListener {
viewModel.deleteContact(contactId)
finish()
}
buttonBack.setOnClickListener {
val replyIntent = Intent()
setResult(Activity.RESULT_CANCELED, replyIntent)
finish()
}
}
override fun onActivityResult(requestCode: Int, resultCode: Int, intentData: Intent?) {
if (requestCode == createContactActivityRequestCode && resultCode == Activity.RESULT_OK ) {
val modifiedIntent = Intent()
val modifiedContact = intentData?.getParcelableExtra<ContactDatabase>("contact")
Timber.i("modifiedContact : " + modifiedContact.toString())
val contact: Contact = Contact(
id = modifiedContact!!.id.toString(),
firstName = modifiedContact!!.firstName,
lastName = modifiedContact!!.lastName,
mail = modifiedContact!!.mail
)
modifiedIntent.putExtra("action", "modify")
modifiedIntent.putExtra("contact", contact)
setResult(Activity.RESULT_OK, modifiedIntent)
finish()
}
super.onActivityResult(requestCode, resultCode, intentData)
}
}
The repository : ContactRepository.kt
package fr.dleurs.android.contactapp.repository
import android.util.Log
import androidx.lifecycle.LiveData
import androidx.lifecycle.Transformations
import fr.dleurs.android.contactapp.database.*
import fr.dleurs.android.contactapp.model.Contact
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.withContext
import timber.log.Timber
import fr.dleurs.android.contactapp.network.asDatabaseModel
import java.util.logging.Level.INFO
class ContactRepository(private val contactDtbDao: ContactDtbDao) {
val contacts: LiveData<List<Contact>> =
Transformations.map(contactDtbDao.getContacts()) {
it.asDomainModel()
}
fun contact(contactId: String): LiveData<Contact> =
Transformations.map(contactDtbDao.getContact(contactId)) { it.asDomailModel() }
suspend fun refreshContacts() {
withContext(Dispatchers.IO) {
Log.i("ContactRepo", "Refresh contacts is called");
val contactList = ContactRetrofitApi.contacts.getContacts()
Log.i("ContactRepo", "ContactList created ${contactList.toString()}");
contactDtbDao.insertAll(contactList.asDatabaseModel())
}
}
suspend fun insertContact(contact: ContactDatabase) {
withContext(Dispatchers.IO) {
contactDtbDao.insert(contact);
}
}
suspend fun deleteContact(contactId: String) {
withContext(Dispatchers.IO) {
contactDtbDao.delete(contactId);
}
}
suspend fun updateContact(contact: ContactDatabase) {
withContext(Dispatchers.IO) {
contactDtbDao.update(contact);
}
}
}
The working ViewModel, ContactsViewModel.kt :
package fr.dleurs.android.contactapp.viewmodel
import android.app.Application
import android.util.Log
import androidx.lifecycle.*
import fr.dleurs.android.contactapp.database.ContactDatabase
import fr.dleurs.android.contactapp.database.ContactsDatabase
import fr.dleurs.android.contactapp.model.Contact
import fr.dleurs.android.contactapp.repository.ContactRepository
import kotlinx.coroutines.launch
import java.io.IOException
class ContactsViewModel(application: Application) : AndroidViewModel(application) {
//private val contactsRepository = ContactRepository(ContactsDatabase.getDatabase(application))
private val contactsRepository = ContactRepository(ContactsDatabase.getInstance(application).contactDtbDao())
var liveContacts: LiveData<List<Contact>> = contactsRepository.contacts
public fun insertContact(contact: ContactDatabase) {
viewModelScope.launch {
contactsRepository.insertContact(contact);
}
}
/**
* Event triggered for network error. This is private to avoid exposing a
* way to set this value to observers.
*/
private var _eventNetworkError = MutableLiveData<Boolean>(false)
/**
* Event triggered for network error. Views should use this to get access
* to the data.
*/
val eventNetworkError: LiveData<Boolean>
get() = _eventNetworkError
/**
* Flag to display the error message. This is private to avoid exposing a
* way to set this value to observers.
*/
private var _isNetworkErrorShown = MutableLiveData<Boolean>(false)
/**
* Flag to display the error message. Views should use this to get access
* to the data.
*/
val isNetworkErrorShown: LiveData<Boolean>
get() = _isNetworkErrorShown
/**
* init{} is called immediately when this ViewModel is created.
*/
init {
refreshDataFromRepository()
}
/**
* Refresh data from the repository. Use a coroutine launch to run in a
* background thread.
*/
private fun refreshDataFromRepository() {
viewModelScope.launch {
try {
contactsRepository.refreshContacts()
_eventNetworkError.value = false
_isNetworkErrorShown.value = false
} catch (networkError: IOException) {
// Show a Toast error message and hide the progress bar.
Log.i("ContactViewModel", "Error on refreshContact : ${networkError.toString()}")
if (liveContacts.value.isNullOrEmpty())
_eventNetworkError.value = true
}
}
}
/**
* Resets the network error flag.
*/
fun onNetworkErrorShown() {
_isNetworkErrorShown.value = true
}
class Factory(val app: Application) : ViewModelProvider.Factory {
override fun <T : ViewModel?> create(modelClass: Class<T>): T {
if (modelClass.isAssignableFrom(ContactsViewModel::class.java)) {
#Suppress("UNCHECKED_CAST")
return ContactsViewModel(app) as T
}
throw IllegalArgumentException("Unable to construct viewmodel")
}
}
}
The working activity, ContactActivity.kt
package fr.dleurs.android.contactapp.ui.main
import android.app.Activity
import android.content.Intent
import android.os.Bundle
import android.widget.Toast
import androidx.appcompat.app.AppCompatActivity
import androidx.lifecycle.ViewModelProvider
import androidx.viewpager.widget.ViewPager
import com.google.android.material.tabs.TabLayout
import fr.dleurs.android.contactapp.R
import fr.dleurs.android.contactapp.database.ContactDatabase
import fr.dleurs.android.contactapp.model.Contact
import fr.dleurs.android.contactapp.model.asDatabaseModel
import fr.dleurs.android.contactapp.ui.detailsContact.DetailsContactActivity
import fr.dleurs.android.contactapp.ui.newModifyContact.CreateModifyContactActivity
import fr.dleurs.android.contactapp.utils.FabButtonInterface
import fr.dleurs.android.contactapp.viewmodel.ContactsViewModel
import timber.log.Timber
public val createContactActivityRequestCode = 1
public val detailContactActivityRequestCode = 2
class ContactActivity : AppCompatActivity(), FabButtonInterface, OnClick {
private lateinit var viewModel: ContactsViewModel
override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
viewModel = ViewModelProvider(
this,
ContactsViewModel.Factory(this.application)
).get(ContactsViewModel::class.java)
setContentView(R.layout.contact_activity)
val sectionsPagerAdapter =
SectionsPagerAdapter(context = this, fm = supportFragmentManager, onClick = this)
val viewPager: ViewPager = findViewById(R.id.contentFragment)
viewPager.adapter = sectionsPagerAdapter
val tabs: TabLayout = findViewById(R.id.tabs)
tabs.setupWithViewPager(viewPager)
}
override fun goToCreateContactActivity() {
Timber.i("Create a new contact started")
val intent = Intent(this, CreateModifyContactActivity::class.java)
startActivityForResult(intent, createContactActivityRequestCode)
}
fun goToDetailContactActivity(contactId: String) {
Timber.i("Details contact started")
val intent = Intent(this, DetailsContactActivity::class.java)
intent.putExtra("contactId", contactId)
startActivity(intent)
}
override fun onActivityResult(requestCode: Int, resultCode: Int, intentData: Intent?) {
super.onActivityResult(requestCode, resultCode, intentData)
if (requestCode == createContactActivityRequestCode && resultCode == Activity.RESULT_OK) {
Timber.i("Intent received")
val response = intentData?.getParcelableExtra<ContactDatabase>("contact")
val newContact = ContactDatabase(
firstName = response!!.firstName,
lastName = response!!.lastName,
mail = response!!.mail
)
Timber.i("Intent received + " + newContact.toString())
viewModel.insertContact(newContact)
} else if (requestCode == createContactActivityRequestCode && resultCode == Activity.RESULT_CANCELED) {
} else if (requestCode == detailContactActivityRequestCode) {
Timber.i("DetailsContactActivity intent :" + intent.toString() + ", intentData: "+intentData.toString()+"resultCode :" + resultCode.toString())
if (resultCode == Activity.RESULT_CANCELED) {
Timber.i("DetailsContactActivity closed with no action")
}
} else {
Toast.makeText(this, "Error creating contact", Toast.LENGTH_LONG).show()
}
}
override fun onItemClick(contactId: String) {
Timber.i("On Item clicked + " + contactId)
goToDetailContactActivity(contactId)
}
}
Thank you for your help !

here you are passing ContactsViewModel::class.java. You have to pass ContactViewModel::class.java
class Factory(val app: Application) : ViewModelProvider.Factory {
override fun <T : ViewModel?> create(modelClass: Class<T>): T {
if (modelClass.isAssignableFrom(ContactViewModel::class.java)) {
#Suppress("UNCHECKED_CAST")
return ContactViewModel(app) as T
}
throw IllegalArgumentException("Unable to construct viewmodel")
}
}