I made a simple tic tac toe game in Kotlin android studio and I'm Trying to make a line after a won game.
for example if X won all three of X will be crossed with line X̶X̶X̶. My representation of that is Indigent, but I think you got the point.
Progress so far:
made two arrays which hold info about each player:
var Player1 = ArrayList<Int>()
var Player2 = ArrayList<Int>()
var ActivePlayer = 1
var setPlayer = 1
gave id to buttons:
fun buttonClick(view: View) {
val buSelected:Button = view as Button
var cellId = 0
when(buSelected.id) {
R.id.button1 -> cellId = 1
R.id.button2 -> cellId = 2
R.id.button3 -> cellId = 3
R.id.button4 -> cellId = 4
R.id.button5 -> cellId = 5
R.id.button6 -> cellId = 6
R.id.button7 -> cellId = 7
R.id.button8 -> cellId = 8
R.id.button9 -> cellId = 9
}
PlayGame(cellId,buSelected)
}
and this is how I check winner:
fun CheckWinner()
{
var winner = -1
//row1
if (Player1.contains(1) && Player1.contains(2) && Player1.contains(3))
{
winner = 1
}
if (Player2.contains(1) && Player2.contains(2) && Player2.contains(3))
{
winner = 2
}
There is more code to it but its too much to add into this post.
User Interface
I recommend create your own custom view instead of using Buttons. You can for example create FrameLayout and put inside TextView and then either show/hide some simple View with line or draw this line with the help of Canvas. That custom view will be 1 of 9 squares. Then just put them in some grid (manually or using RecyclerView or GridView).
Logic
Create two lists that will contain X and O for each player. Lists of ints with square positions will be enough. Fill those lists with positions (from 1 to 9) when one of two users select a square and before add new item (position) to list, check if this item isn't already in the list (this player, player1) and isn't in the other list (other player, player2). If both of two lists don't contain this item - add it. Then, after adding a new position to list, check if it forms a line. For example, 1, 3, 9 or 2, 5, 7. If so, that player won and you can cross those positions.
Code could look like this:
enum Player {
player1,
player2
}
List<int> player1List = List();
List<int> player2List = List();
void addNewPosition(Player player, int position) {
List<int> currentPlayerList;
List<int> otherPlayerList;
switch(player) {
case Player.player1:
currentPlayerList = player1List;
otherPlayerList = player2List;
break;
case Player.player2:
currentPlayerList = player2List;
otherPlayerList = player1List;
break;
}
if (currentPlayerList.contains(position)) {
// this player already selected this position, do nothing
return;
}
if (otherPlayerList.contains(position)) {
// another player already selected this position, do nothing
return;
}
currentPlayerList.add(position); // add selected position to current player list
// now check if current players position forms a line
if (currentPlayerList.contains(1) && currentPlayerList.contains(2) && currentPlayerList.contains(3)) {
// this player won
}
... check other possible solutions that could result in a win. Better to follow some pattern instead of checking each of them
}
Related
I'm trying to make my view move in a loop around 4 corners. I did it by having a keyList. Originally my view is constrained to top and left border.
After each click, I update the keylist by removing first index of keyList and move it to the last.
I have this code currently. The view moves fine for the first 4 corners (1 loop) but the app crashed after.
var keyList = arrayListOf(1,2,3,0,1,2,3,0)
val puckMinX = border.minX().toFloat()
val puckMaxX = (border.maxX() - puck.width).toFloat()
val puckMinY= border.minY().toFloat()
val puckMaxY = (border.maxY() - puck.height).toFloat()
fun clickTextView(view: ImageView) {
if (keyList[0] == 0) {
puck.x = puckMinX
puck.y = puckMinY
var holder =keyList[0]
keyList.remove(holder)
keyList+holder}
else if (keyList[0] == 1) {
puck.x = puckMaxX
puck.y = puckMinY
var holder =keyList[0]
keyList
keyList.remove(holder)
keyList+holder}
else if (keyList[0] == 2) {
puck.x = puckMaxX
puck.y = puckMaxY
var holder =keyList[0]
keyList.remove(holder)
keyList+holder}
else if (keyList[0] == 3) {
puck.x = puckMinX
puck.y = puckMaxY
var holder =keyList[0]
keyList.remove(holder)
keyList+holder}
}
//applying lambda to each textview
puck.setOnClickListener { clickTextView(puck) }
Could someone tell me what I did wrong? Or also is there a better way to make my view move in a loop? Any help is appreciated!
EDIT: I found the problem. My list is only removing the first index but not adding the item that's removed back to the list. How do I update my keylist?
You can use add which adds element to end of the list
keyList.add(holder)
Edit
Note that you wont be able to print like println(keyList.add(holder)) because add will return true since it will successfully update the list. So you will have to do
keyList.add(holder)
println(keyList)
I'm trying to make an animation when my silver's user is updated. The problem is that the animation doesn't stop on the right number.
I'm working with firestore so I retreive the silver value from a Snapchat listener.
Since the ValueAnimator doesn't work proprely with big number I don't want animation for number biger than 2 000 000 000.
var oldSilver :Long = 0
var silver_long :Long = 923364963
if (silver_long>2000000000){
silver_textView.setText(DecimalFormat("#,###").format(silver_long))
} else {
startCountAnimationSilver(oldSilver.toInt(),silver_long.toInt(),2000)
}
private fun startCountAnimationSilver(old:Int,new:Int,duration:Int) {
Toast.makeText(applicationContext,"old = $old new = $new",Toast.LENGTH_LONG).show()
val animator = ValueAnimator.ofInt(old, new)
animator.addUpdateListener { animation -> silver_textView.text = DecimalFormat("#,###").format(animation.animatedValue) }
animator.duration = duration.toLong()
animator.start()
}
The Toast in startCountAnimationSilver was just to make sure that i've got the rights parameters.
For exemple if I try right now, the toast shows : old = 0 new = 923364963
But the silver_textView shows : 923 364 992
I am new to developping in kotlin and for my class, I have a tic tac toe game to create. I initialy create a MutableListOf at the top of my page that contain all the "box" of my playing grid.
private var playingBoard:MutableList<ImageView> = ArrayList()
then i had all the boxes of the grid to the list using a function like so :
private fun activerGrilleDeJeu() {
playingBoard.add(view.a1)
playingBoard.add(view.a2)
playingBoard.add(view.a3)
playingBoard.add(view.b1)
playingBoard.add(view.b2)
playingBoard.add(view.b3)
playingBoard.add(view.c1)
playingBoard.add(view.c2)
playingBoard.add(view.c3)
}
I then have a function that check for a victory when i click on an image view on the board but my problem is that function never seem's to trigger :
private fun victoryListener(): Boolean{
//Horizontal victory
if(playingBoard[0] == playingBoard[1] && playingBoard[0] == playingBoard[2] && playingBoard[1] == playingBoard[2]){
return true
}
this is how i call that function
grilleDeJeu[0].setOnClickListener {
ajouterjeton(grilleDeJeu[0])
if(victoryListener()){
if(tourPresent == joueur1){
joueur1.score += 1
tourPresent = joueur1
resultat("Victoire de ${joueur1.prenom}")
}
else{
joueur2.score += 1
tourPresent = joueur2
resultat("Victoire de ${joueur2.prenom}")
}
}
I had the same function for every "box" of the grid so I didn't had all of them but if you guy's need the full code just ask and i'll post it.
I have two list, one with all possible devices and another with just few devices. I need pass final list with this condition:
if full list == one of the items in smaller list, make this item "active" too true, else leave it false.
I have no problem when working with full list >500 devices and small list >50, but when I have for example 2000 devices everything start to be too slow (on Google Pixel 2XL I need to wait about 6 seconds to job finish).
Question: how can I increase this loop speed?
What I have done so far:
devicesList.forEach { device ->
device.selected = false
items.forEach { it ->
if(it.id == device.id){
device.selected = true
}
}
But this is too slow for larger data
You can speed it up a bit by not using forEach, which uses an interator and instead use a for loop. You can also break once you locate your id, assuming they are unique
for (i in 0 until devicesList.size) {
val device = devicesList[i]
for (j in 0 until items.size) {
val item = items[j]
if (item.id == device.id) {
device.selected = true
break
}
}
}
Assuming your ids are unique, you could also make a duplicate of the items list and drop those that have been located, so each loop is shorter, like this
val copy = items.toMutableList()
for (i in 0 until devicesList.size) {
val device = devicesList[i]
for (j in 0 until copy.size) {
val item = copy[j]
if (item.id == device.id) {
device.selected = true
copy.remove(item)
break
}
}
}
You could also consider creating a map where the key is your id so you do not have to loop and instead you retrieve the item by id directly. You have to weight the cost of creating the map in the first place.
val map = items.associateBy { it.id }
for (i in 0 until devicesList.size) {
val device = devicesList[i]
device.selected = map[device.id] != null
}
Besides this, you should also move your logic to a background thread and wait for it to complete.
If all you need is make selected = true if a device's id exists in the list items, you can get all the ids of items like this:
val ids = items.map { it.id }
and then loop through devices:
devicesList.forEach { it.selected = it.id in ids }
I have a list of 30 random numbers that correspond to 1 of 8 colours, and I need to iterate over the 8 colors(or 30 numbers) and find the number of times each colour occurs. I need to do this using lambdas and functional programming, so no traditional for loops.
val iterator = colours.toList().iterator()
iterator.forEach{
println("$it count: " + (numbers
.map{a -> colours[a]}
.count{it == ("$it")}))
}
The problem currently is my output for count is just 50, not the specific number of times a colour occurs.
If I do it like this:
println("Red count:" + (numbers
.map{a -> colours[a]}
.count{it == ("red")}))
it outputs the correct number, but not with the loop.
What it ouputs:
green count: 50
red count: 50
what it should output (for example)
green count:9
red count:3
Thanks in advance
Add a named parameter to your forEach loop. The implicit name "it" is getting shadowed by the count function.
val iterator = colours.toList().iterator()
iterator.forEach { colour ->
println("$colour count: " + (numbers
.map{a -> colours[a]}
.count{it == ("$colour")}))
}
You don't really need to do a nested iteration here. Currently you're operating at O(n^2) since you have to traverse the list once for every element. Since you know you're working with a small number of potential values, you could instead just group them by value and then map the values to the size of the resulting lists, i.e.
val colourNames = listOf("red", "green", "blue", "yellow", "orange", "indigo", "violet", "black")
// Generates 30 random numbers between 0 and 8 (exclusive)
val randomColours = (0 until 30).map { (0 until colourNames.size).random() }
val result = randomColours
.groupBy { color -> colourNames[color] } // outputs a Map<String, List<Int>>
.mapValues { (color, colorCountList) -> colorCountList.size } // Map<String, Int>
println(result) // {yellow=4, orange=4, red=5, indigo=3, blue=8, green=2, violet=2, black=2}